Use device class selector for KNX - #180289
Conversation
|
Hey there @Julius2342, @farmio, @marvin-w, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
farmio
left a comment
There was a problem hiding this comment.
Thanks! I'll put this to draft until tested in the Knx config panel. Not sure if our version of the frontend already supports that selector.
|
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
The front PR was merged and will be in the beta |
|
The knx config panel runs in an iframe - it has no access to the core frontend componenes. It needs to ship its own HA frontend. |
|
After #180338 it will be fine. |
|
Is it possible to explicitly deselect a device class or set it to |
The selector is optional. So yes, this allows to clear the |
|
Omitting the value results in using the default device_class for the selected datapoint type. Do you think it would be accepted to add a Boolean option to the selector to show an explicit |
|
Have a look at the MQTT subentry setup by adding an MQTT device. Choose "sensor". |
|
In you current code base the selector is already optional. Also the values are exact the same as in your previous |
|
Yes right. When it is None, it falls back to the default - which isn't None depending on other config options. We don't have the override-to-None feature yet. There was another blocker. |
Proposed change
Use device class selector for KNX
Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.To help with the load of incoming pull requests: