Raise Sofar to the silver quality scale - #180292
Open
darkrain-nl wants to merge 6 commits into
Open
Conversation
Cover the coordinator's four uncovered failure paths: an all-failed poll, an empty report, a component that answers the retry, and a link that dies during the retry. coordinator.py goes from 92% to 100%, which is what test-coverage was already claiming in quality_scale.yaml.
home-assistant
Bot
added
cla-signed
code-quality
has-tests
integration: sofar
small-pr
8 tasks
Contributor
There was a problem hiding this comment.
Pull request overview
Raises the Sofar integration to Silver quality status by completing coordinator failure-path coverage.
Changes:
- Adds tests for poll, report, retry, and connection failures.
- Updates the integration’s quality-scale declaration to Silver.
- Silver requirements are satisfied.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
tests/components/sofar/test_coordinator.py |
Adds coordinator failure and recovery tests. |
homeassistant/components/sofar/manifest.json |
Declares Silver quality status. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
joostlek
requested changes
Aug 26, 2026
Contributor
|
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
darkrain-nl
marked this pull request as ready for review
August 26, 2026 17:02
Contributor
Author
|
PR #180306 is now merged. |
# Conflicts: # homeassistant/components/sofar/manifest.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed change
Raise Sofar to silver on the quality scale.
Needs #180306 to be merged first.
Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.To help with the load of incoming pull requests: