Skip to content

Add battery charge current limit number entity to GoodWe - #180293

Closed
davibe wants to merge 1 commit into
home-assistant:devfrom
davibe:goodwe-battery-charge-current
Closed

Add battery charge current limit number entity to GoodWe#180293
davibe wants to merge 1 commit into
home-assistant:devfrom
davibe:goodwe-battery-charge-current

Conversation

@davibe

@davibe davibe commented Aug 26, 2026

Copy link
Copy Markdown

Adds a Battery charge current limit number entity to the GoodWe integration, exposing the inverter's battery_charge_current setting (Modbus register 45353) under the device's configuration entities.

The entity is only created when the inverter advertises the setting, and is read/written through read_setting/write_setting with the register's 0.1 A resolution. The 0–100 A range is GoodWe's documented range for the register (BattChargeCurrMax RW U16 gain 10 [0,1000]), not a per-model hardware limit; the inverter and battery BMS still apply their own limits. It's a current ceiling: actual charging power depends on battery voltage, available PV power, load, inverter mode and BMS limits.

Related: mletenay/home-assistant-goodwe-inverter#413

Type of change

  • New feature (which adds functionality to an existing integration)

Copilot AI balanced review requested due to automatic review settings August 26, 2026 15:13
@davibe
davibe requested a review from starkillerOG as a code owner August 26, 2026 15:13

@home-assistant home-assistant Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @davibe

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

@home-assistant

Copy link
Copy Markdown
Contributor

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@home-assistant
home-assistant Bot marked this pull request as draft August 26, 2026 15:14
@home-assistant

Copy link
Copy Markdown
Contributor

Hey there @mletenay, @starkillerOG, mind taking a look at this pull request as it has been labeled with an integration (goodwe) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of goodwe can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant mark-draft Mark the pull request as draft.
  • @home-assistant ready-for-review Remove the draft status from the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign goodwe Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant update-branch Update the pull request branch with the base branch.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component, problem in config, problem in device, feature-request) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component, problem in config, problem in device, feature-request) on the pull request.

@davibe
davibe force-pushed the goodwe-battery-charge-current branch from 2615677 to 89d7f82 Compare August 26, 2026 15:26

@home-assistant home-assistant Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @davibe

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

@davibe davibe closed this Aug 26, 2026
@davibe davibe reopened this Aug 26, 2026

@home-assistant home-assistant Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @davibe

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

@davibe davibe closed this Aug 26, 2026
@davibe

davibe commented Aug 26, 2026

Copy link
Copy Markdown
Author

Superseded by #180296 — the PR template's "Type of change" checkbox was missing when this PR was opened, so the label bot never applied the required label.

@davibe
davibe removed the request for review from Copilot August 26, 2026 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants