Add battery charge current limit number entity to GoodWe - #180296
Open
davibe wants to merge 1 commit into
Open
Conversation
1 task
Contributor
|
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
Contributor
|
Hey there @mletenay, @starkillerOG, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
davibe
force-pushed
the
goodwe-battery-charge-current
branch
from
August 26, 2026 15:40
89d7f82 to
e875471
Compare
davibe
force-pushed
the
goodwe-battery-charge-current
branch
from
August 26, 2026 18:03
e875471 to
a544c8d
Compare
| # Battery charge current limit in A (inverter side, BMS limits still apply). | ||
| # Only added when the inverter advertises the setting. | ||
| GoodweNumberEntityDescription( | ||
| key="battery_charge_current", |
davibe
marked this pull request as ready for review
August 26, 2026 18:08
joostlek
requested changes
Aug 30, 2026
joostlek
left a comment
Member
There was a problem hiding this comment.
Please fill in the PR template
davibe
force-pushed
the
goodwe-battery-charge-current
branch
from
September 1, 2026 17:27
a544c8d to
e667546
Compare
davibe
marked this pull request as ready for review
September 1, 2026 17:31
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed change
Adds a Battery charge current limit number entity to the GoodWe integration, exposing the inverter's
battery_charge_currentsetting (Modbus register 45353) under the device's configuration entities.The entity is only created when the inverter advertises the setting (
inverter.settings()containsbattery_charge_current), so model families without the register get no entity and no register read is attempted. It is read/written throughread_setting/write_settingwith the register's 0.1 A resolution (aconverterfield was added to the entity description so the existing whole-number settings keep theirintconversion while this one usesround(value, 1)).The 0–100 A range is GoodWe's documented range for the register (
BattChargeCurrMax RW U16 gain 10 [0,1000]in the ARM Modbus protocol map), not a per-model hardware limit; per that documentation the inverter and battery BMS still apply their own real-time limits. It's a current ceiling: actual charging power depends on battery voltage, available PV power, load, inverter mode and BMS limits. The entity uses box input mode (no slider) andEntityCategory.CONFIG.Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.To help with the load of incoming pull requests: