Add system sensors to libreNMS - #180300
Open
mib1185 wants to merge 4 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds LibreNMS system-level sensors for device count and software versions.
Changes:
- Registers and implements the sensor platform.
- Adds a LibreNMS service device, translations, and icons.
- Adds snapshot coverage for sensors and device metadata.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
homeassistant/components/librenms/__init__.py |
Registers the sensor platform. |
homeassistant/components/librenms/entity.py |
Adds the system service entity base. |
homeassistant/components/librenms/icons.json |
Defines sensor icons. |
homeassistant/components/librenms/sensor.py |
Implements system sensors. |
homeassistant/components/librenms/strings.json |
Adds sensor translations. |
tests/components/librenms/test_sensor.py |
Tests sensor setup and registration. |
tests/components/librenms/snapshots/test_sensor.ambr |
Captures sensor and device snapshots. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 7 out of 7 changed files in this pull request and generated no new comments.
Suppressed comments (1)
homeassistant/components/librenms/sensor.py:107
- Use the config entry ID for these entity unique IDs. The config flow never assigns
ConfigEntry.unique_id, so every sensor currently gets values such asNone_device_count(as the snapshot confirms); a second LibreNMS entry would therefore collide with the first entry's entities.
self._attr_unique_id = f"{coordinator.config_entry.unique_id}_{description.key}"
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed change
This adds the sensor platform and the first bunch of libreNMS system related sensors.
Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.To help with the load of incoming pull requests: