Skip to content

Use SmartThings custom setpoint bounds for air conditioners - #180304

Open
StellarSea wants to merge 2 commits into
home-assistant:devfrom
StellarSea:smartthings-ac-custom-setpoint-bounds
Open

Use SmartThings custom setpoint bounds for air conditioners#180304
StellarSea wants to merge 2 commits into
home-assistant:devfrom
StellarSea:smartthings-ac-custom-setpoint-bounds

Conversation

@StellarSea

Copy link
Copy Markdown
Contributor

Proposed change

Note

Depends on #180299 — that branch is the base of this one, so this diff only makes sense on top of it. Happy to rebase once it lands.

Some Samsung air conditioners report thermostatCoolingSetpoint.coolingSetpointRange as null while exposing a complete, unit-bearing range through custom.thermostatSetpointControl on the same component. #178430 only looked at the former, so those devices stay on the generic 7–35 °C defaults even though the device tells us what it supports.

Reported in #178814 for DA-AC-RAC-000003 / ARTIK051_PRAC_20K, confirmed on four physical units:

thermostatCoolingSetpoint.coolingSetpointRange: null
custom.thermostatSetpointControl.minimumSetpoint: 61 F
custom.thermostatSetpointControl.maximumSetpoint: 86 F

min_temp/max_temp now fall back to those bounds before the generic defaults, so the order becomes coolingSetpointRangecustom.thermostatSetpointControl → defaults.

SmartThingsHeatPumpZone already reads the same capability, including the -1000 sentinel devices use to say a bound is unavailable, so this applies an existing pattern in this file to air conditioners rather than introducing a new one. As there, -1000 and null fall through to the next source. The bounds carry their own unit, which is converted to the entity unit and defaults to it when absent (da_ac_rac_100001 reports the values without a unit).

Four existing fixtures move off the generic defaults as a result — da_ac_rac_000001, da_ac_rac_000003, da_ac_rac_100001 and da_ac_rac_000001's second entity — all to 16–30 °C, which is what those devices report. aux_ac does not have the capability and keeps the defaults.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • I understand the code I am submitting and can explain how it works.
  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.
  • Any generated code has been carefully reviewed for correctness and compliance with project standards.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
  • New or updated dependencies have been added to requirements_all.txt.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

StellarSea and others added 2 commits August 27, 2026 00:46
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Copilot AI balanced review requested due to automatic review settings August 26, 2026 15:50
@StellarSea
StellarSea requested a review from joostlek as a code owner August 26, 2026 15:50
@home-assistant home-assistant Bot added bugfix cla-signed has-tests integration: smartthings Top 100 Integration is ranked within the top 100 by usage Top 200 Integration is ranked within the top 200 by usage labels Aug 26, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@home-assistant

Copy link
Copy Markdown
Contributor

Hey there @joostlek, mind taking a look at this pull request as it has been labeled with an integration (smartthings) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of smartthings can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant mark-draft Mark the pull request as draft.
  • @home-assistant ready-for-review Remove the draft status from the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign smartthings Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant update-branch Update the pull request branch with the base branch.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component, problem in config, problem in device, feature-request) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component, problem in config, problem in device, feature-request) on the pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugfix cla-signed has-tests integration: smartthings Quality Scale: bronze Top 100 Integration is ranked within the top 100 by usage Top 200 Integration is ranked within the top 200 by usage

Projects

None yet

Development

Successfully merging this pull request may close these issues.

SmartThings AC with null coolingSetpointRange ignores available custom setpoint bounds

3 participants