Use SmartThings custom setpoint bounds for air conditioners - #180304
Open
StellarSea wants to merge 2 commits into
Open
Use SmartThings custom setpoint bounds for air conditioners#180304StellarSea wants to merge 2 commits into
StellarSea wants to merge 2 commits into
Conversation
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Contributor
|
Hey there @joostlek, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed change
Note
Depends on #180299 — that branch is the base of this one, so this diff only makes sense on top of it. Happy to rebase once it lands.
Some Samsung air conditioners report
thermostatCoolingSetpoint.coolingSetpointRangeasnullwhile exposing a complete, unit-bearing range throughcustom.thermostatSetpointControlon the same component. #178430 only looked at the former, so those devices stay on the generic 7–35 °C defaults even though the device tells us what it supports.Reported in #178814 for
DA-AC-RAC-000003/ARTIK051_PRAC_20K, confirmed on four physical units:min_temp/max_tempnow fall back to those bounds before the generic defaults, so the order becomescoolingSetpointRange→custom.thermostatSetpointControl→ defaults.SmartThingsHeatPumpZonealready reads the same capability, including the-1000sentinel devices use to say a bound is unavailable, so this applies an existing pattern in this file to air conditioners rather than introducing a new one. As there,-1000andnullfall through to the next source. The bounds carry their own unit, which is converted to the entity unit and defaults to it when absent (da_ac_rac_100001reports the values without a unit).Four existing fixtures move off the generic defaults as a result —
da_ac_rac_000001,da_ac_rac_000003,da_ac_rac_100001andda_ac_rac_000001's second entity — all to 16–30 °C, which is what those devices report.aux_acdoes not have the capability and keeps the defaults.Type of change
Additional information
coolingSetpointRangeignores available custom setpoint bounds #178814Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
requirements_all.txt.