Fix AirGradient VOC and NOx learning offset units - #180305
Open
samuelbles07 wants to merge 1 commit into
Open
Conversation
home-assistant
Bot
added
bugfix
cla-signed
has-tests
integration: airgradient
small-pr
Contributor
|
Hey there @airgradienthq, @joostlek, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
Contributor
There was a problem hiding this comment.
Pull request overview
Corrects AirGradient NOx and VOC learning offset sensors to report API values in hours.
Changes:
- Changes both duration sensors from days to hours.
- Updates snapshots for all supported device variants.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
homeassistant/components/airgradient/sensor.py |
Corrects learning offset units. |
tests/components/airgradient/snapshots/test_sensor.ambr |
Updates expected sensor units. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Breaking change
None.
Proposed change
Correct the AirGradient NOx and VOC learning offset diagnostic sensors to report hours instead of days, matching the device API values and configuration select labels.
Validation
uv run --no-sync pytest tests/components/airgradient --cov=homeassistant.components.airgradient --cov-report=term-missing(84 passed, 172 snapshots, 100% coverage)Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running:
python3 -m script.gen_requirements_all.To help with the load of incoming pull requests: