Skip to content

Recognize AirGradient 0-1PS as an outdoor model #180313

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
samuelbles07 wants to merge 1 commit into
base: dev
Choose a base branch
from
+13 −8
Open

Recognize AirGradient 0-1PS as an outdoor model #180313

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions homeassistant/components/airgradient/const.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,6 +71,11 @@ class ModelCapabilities:
}
)

OUTDOOR_CAPABILITIES = ModelCapabilities(
config=COMMON_LEGACY_CONFIG,
actions=frozenset({CO2_CALIBRATION}),
)

MODEL_CAPABILITIES: tuple[tuple[str, ModelCapabilities], ...] = (
(
"I-9PSL",
Expand All @@ -86,13 +91,8 @@ class ModelCapabilities:
actions=frozenset({CO2_CALIBRATION, LED_BAR_TEST}),
),
),
(
"O-1",
ModelCapabilities(
config=COMMON_LEGACY_CONFIG,
actions=frozenset({CO2_CALIBRATION}),
),
),
("O-1", OUTDOOR_CAPABILITIES),
("0-1PS", OUTDOOR_CAPABILITIES),
(
"DIY",
ModelCapabilities(
Expand Down
7 changes: 6 additions & 1 deletion tests/components/airgradient/test_init.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
import pytest
from syrupy.assertion import SnapshotAssertion

from homeassistant.components.airgradient.const import DOMAIN
from homeassistant.components.airgradient.const import DOMAIN, get_model_capabilities
from homeassistant.config_entries import ConfigEntryState
from homeassistant.const import Platform
from homeassistant.core import HomeAssistant
Expand All @@ -19,6 +19,11 @@
from tests.common import MockConfigEntry, async_fire_time_changed


def test_outdoor_model_alias() -> None:
"""Test the outdoor model firmware typo uses outdoor capabilities."""
assert get_model_capabilities("0-1PS") == get_model_capabilities("O-1PPT")


async def test_device_info(
hass: HomeAssistant,
snapshot: SnapshotAssertion,
Expand Down
Loading