Improve Monzo API errors, icon, and test coverage - #180320
Open
JakeMartin-ICL wants to merge 2 commits into
Open
Improve Monzo API errors, icon, and test coverage#180320JakeMartin-ICL wants to merge 2 commits into
JakeMartin-ICL wants to merge 2 commits into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Improves Monzo integration diagnostics, transaction presentation, and edge-case coverage.
Changes:
- Adds translated coordinator errors with debug-only API response details.
- Adds a transaction-specific event icon.
- Expands invalid-response and account-owner tests.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
homeassistant/components/monzo/coordinator.py |
Raises translated update failures. |
homeassistant/components/monzo/strings.json |
Defines new error translations. |
homeassistant/components/monzo/icons.json |
Adds the transaction event icon. |
tests/components/monzo/test_sensor.py |
Tests invalid API responses and availability. |
tests/components/monzo/test_helpers.py |
Tests owner metadata edge cases. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Breaking change
Proposed change
This makes several small improvements to the Monzo integration:
Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.To help with the load of incoming pull requests: