Add icons, state translations and enum mapping for OpenEVSE status sensor - #180329
Open
firstof9 wants to merge 4 commits into
Open
Add icons, state translations and enum mapping for OpenEVSE status sensor#180329firstof9 wants to merge 4 commits into
firstof9 wants to merge 4 commits into
Conversation
Contributor
|
Hey there @c00w, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
Contributor
There was a problem hiding this comment.
Pull request overview
Adds translated enum states and icons to improve OpenEVSE entity presentation.
Changes:
- Maps charging statuses to enum-compatible snake_case values.
- Adds state translations and icons.
- Updates status tests and snapshots.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
homeassistant/components/openevse/sensor.py |
Adds status enum mapping. |
homeassistant/components/openevse/strings.json |
Adds status translations. |
homeassistant/components/openevse/icons.json |
Adds entity and state icons. |
tests/components/openevse/test_sensor.py |
Tests status mappings. |
tests/components/openevse/snapshots/test_sensor.ambr |
Updates enum snapshots. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
zweckj
reviewed
Aug 27, 2026
| ] | ||
|
|
||
| STATUS_MAP: dict[str, str] = { | ||
| "unknown": "unknown", |
Member
There was a problem hiding this comment.
wouldn't it be easier to just replace any dash or space with an underscore?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Breaking change
The OpenEVSE
status(Charging status) sensor states are now converted to snake_case enum values (e.g.,charging,not_connected,gfci_self_test_failure). Existing automations or scripts checking for previous raw state values (such asChargingornot connected) will need to be updated to match the new enum state values.Proposed change
Adds icons and state translations for OpenEVSE sensors/binary sensors, maps the charging
statussensor to snake_case enum options (SensorDeviceClass.ENUM), and updates tests and snapshots.This supersedes and resolves review comments on #174420.
Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.To help with the load of incoming pull requests: