Skip to content

Disable GoodWe timestamp sensor by default - #180336

Open
jstsch wants to merge 2 commits into
home-assistant:devfrom
jstsch:goodwe-disable-timestamp-default
Open

Disable GoodWe timestamp sensor by default#180336
jstsch wants to merge 2 commits into
home-assistant:devfrom
jstsch:goodwe-disable-timestamp-default

Conversation

@jstsch

@jstsch jstsch commented Aug 26, 2026

Copy link
Copy Markdown

Proposed change

Disable the GoodWe inverter timestamp sensor by default.

The inverter timestamp changes on every coordinator update. Because it is exposed as a text sensor, these changes produce frequent entries in Home Assistant's Activity/Logbook view (in my case, every 10 seconds). Example:

image

The entity remains available and can be enabled manually by users who need the inverter timestamp for diagnostics or automations. Observed with a GoodWe GW2000-XS: the timestamp entity updates at each inverter poll and fills the Activity view with timestamp state changes.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:
  • Link to developer documentation pull request:
  • Link to frontend pull request:

Checklist

  • I understand the code I am submitting and can explain how it works.
  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.
  • Any generated code has been carefully reviewed for correctness and compliance with project standards.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies a diff between library versions and ideally a link to the changelog/release notes is added to the PR description.

To help with the load of incoming pull requests:

Copilot AI balanced review requested due to automatic review settings August 26, 2026 19:43
@jstsch
jstsch requested a review from starkillerOG as a code owner August 26, 2026 19:43

@home-assistant home-assistant Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @jstsch

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

@home-assistant home-assistant Bot added bugfix cla-needed dependency Pull requests marked as a dependency upgrade integration: goodwe small-pr PRs with less than 30 lines. labels Aug 26, 2026
@home-assistant

Copy link
Copy Markdown
Contributor

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@home-assistant

Copy link
Copy Markdown
Contributor

Hey there @mletenay, @starkillerOG, mind taking a look at this pull request as it has been labeled with an integration (goodwe) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of goodwe can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant mark-draft Mark the pull request as draft.
  • @home-assistant ready-for-review Remove the draft status from the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign goodwe Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant update-branch Update the pull request branch with the base branch.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component, problem in config, problem in device, feature-request) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component, problem in config, problem in device, feature-request) on the pull request.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Disables the GoodWe inverter timestamp sensor by default to reduce frequent Activity/Logbook entries.

Changes:

  • Marks the timestamp sensor as disabled by default while allowing manual enablement.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread homeassistant/components/goodwe/sensor.py
@jstsch
jstsch marked this pull request as ready for review August 26, 2026 19:57

@erwindouna erwindouna left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for contributing. The PR has been tempered with. Please restore it. :)

@home-assistant
home-assistant Bot marked this pull request as draft August 26, 2026 21:08
@jstsch
jstsch marked this pull request as ready for review August 27, 2026 14:51
@home-assistant
home-assistant Bot requested a review from erwindouna August 27, 2026 14:51
Copilot AI review requested due to automatic review settings August 29, 2026 14:30

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.

@erwindouna

Copy link
Copy Markdown
Member

I'd like to have a second opinion of a codeowner if this is feasible. Can you have a look, @starkillerOG? :)

@joostlek

Copy link
Copy Markdown
Member

I am actually wondering if this should belong in the state machine, given it's the current time so it'd always have an update

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugfix cla-signed dependency Pull requests marked as a dependency upgrade integration: goodwe Quality Scale: No score small-pr PRs with less than 30 lines.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants