Disable GoodWe timestamp sensor by default - #180336
Conversation
|
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
|
Hey there @mletenay, @starkillerOG, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
There was a problem hiding this comment.
Pull request overview
Disables the GoodWe inverter timestamp sensor by default to reduce frequent Activity/Logbook entries.
Changes:
- Marks the timestamp sensor as disabled by default while allowing manual enablement.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
erwindouna
left a comment
There was a problem hiding this comment.
Thanks for contributing. The PR has been tempered with. Please restore it. :)
|
I'd like to have a second opinion of a codeowner if this is feasible. Can you have a look, @starkillerOG? :) |
|
I am actually wondering if this should belong in the state machine, given it's the current time so it'd always have an update |
Proposed change
Disable the GoodWe inverter
timestampsensor by default.The inverter timestamp changes on every coordinator update. Because it is exposed as a text sensor, these changes produce frequent entries in Home Assistant's Activity/Logbook view (in my case, every 10 seconds). Example:
The entity remains available and can be enabled manually by users who need the inverter timestamp for diagnostics or automations. Observed with a GoodWe GW2000-XS: the timestamp entity updates at each inverter poll and fills the Activity view with timestamp state changes.
Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.To help with the load of incoming pull requests: