-
Notifications
You must be signed in to change notification settings - Fork 26
feat(horde): improve ActiveSync admin device table UI #114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
62bfb3a
feat(horde): improve ActiveSync admin device table UI
TDannhauer deec450
Potential fix for pull request finding
TDannhauer 82cf163
Update horde.pot for ActiveSync device table strings
Copilot 0c34a02
Restore missing msgid "unified" in de.po
Copilot 67afe4e
Potential fix for pull request finding
TDannhauer File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,93 @@ | ||
| <?php | ||
|
|
||
| /** | ||
| * Helpers for rendering ActiveSync device tables. | ||
| * | ||
| * Copyright 2026 Horde LLC (http://www.horde.org/) | ||
| * | ||
| * @license http://www.horde.org/licenses/lgpl LGPL-2 | ||
| * @package Horde | ||
| */ | ||
|
|
||
| /** | ||
| * Build sorted, optionally grouped device table entries for templates. | ||
| */ | ||
| class Horde_ActiveSync_DeviceTable | ||
| { | ||
| /** | ||
| * Sort device rows. | ||
| * | ||
| * @param array<int, array{device: Horde_ActiveSync_Device, collections: array}> $rows | ||
| * @param bool $byUser If true, sort by username first. | ||
| */ | ||
| public static function sortRows(array $rows, bool $byUser = true): array | ||
| { | ||
| usort( | ||
| $rows, | ||
| function (array $a, array $b) use ($byUser) { | ||
| if ($byUser) { | ||
| $cmp = strcasecmp($a['device']->user, $b['device']->user); | ||
| if ($cmp !== 0) { | ||
| return $cmp; | ||
| } | ||
| } | ||
|
|
||
| $cmp = strcasecmp($a['device']->deviceType, $b['device']->deviceType); | ||
| if ($cmp !== 0) { | ||
| return $cmp; | ||
| } | ||
|
|
||
| return strcasecmp($a['device']->id, $b['device']->id); | ||
| } | ||
| ); | ||
|
|
||
| return $rows; | ||
| } | ||
|
|
||
| /** | ||
| * Convert rows to template entries, optionally with user group headers. | ||
| * | ||
| * @param array<int, array{device: Horde_ActiveSync_Device, collections: array}> $rows | ||
| * | ||
| * @return array<int, array<string, mixed>> | ||
| */ | ||
| public static function toEntries(array $rows, bool $groupByUser = false): array | ||
| { | ||
| if (!$groupByUser) { | ||
| $entries = []; | ||
| foreach ($rows as $row) { | ||
| $entries[] = [ | ||
| 'type' => 'device', | ||
| 'device' => $row['device'], | ||
| 'collections' => $row['collections'], | ||
| ]; | ||
| } | ||
|
|
||
| return $entries; | ||
| } | ||
|
|
||
| $groups = []; | ||
| foreach ($rows as $row) { | ||
| $groups[$row['device']->user][] = $row; | ||
| } | ||
| ksort($groups, SORT_NATURAL | SORT_FLAG_CASE); | ||
|
|
||
| $entries = []; | ||
| foreach ($groups as $user => $userRows) { | ||
| $entries[] = [ | ||
| 'type' => 'header', | ||
| 'user' => $user, | ||
| 'count' => count($userRows), | ||
| ]; | ||
| foreach ($userRows as $row) { | ||
| $entries[] = [ | ||
| 'type' => 'device', | ||
| 'device' => $row['device'], | ||
| 'collections' => $row['collections'], | ||
| ]; | ||
| } | ||
| } | ||
|
|
||
| return $entries; | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binary file not shown.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binary file not shown.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binary file not shown.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binary file not shown.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binary file not shown.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binary file not shown.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binary file not shown.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binary file not shown.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binary file not shown.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binary file not shown.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binary file not shown.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.