Repository navigation
Libpitt/2008 render error - #2009
Merged
Merged
Conversation
yuanzhou
approved these changes
Sep 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change log:
error_detailsvalue for RenderError method.@yuanzhou I am not sure how this method is being used or triggered. This is the code that was there before:
console.debug("USEEFFECT", props.errorMSG);And I then changed it to:
logger.all.error({message: 'RenderError', error_details: props.errorMSG});To ingest whatever the error is. I added
props.error. Maybe that has some additional details.logger.all.error({message: 'RenderError', error_details:${props.errorMSG} ${props.error}});