Repository navigation
NickAkhmetov/CAT-44 Match fullscreen visualization header to dark theme - #4112
Open
NickAkhmetov wants to merge 1 commit into
Open
NickAkhmetov wants to merge 1 commit into
NickAkhmetov wants to merge 1 commit into
Conversation
When a visualization is fullscreen and its theme is dark, wrap the entity header in darkTheme so it matches the visualization it sits on. Outside fullscreen the header is not attached to the visualization, so it stays light. The WhiteBackground* buttons hard-coded #fff, which left dark-mode primary icons nearly invisible. They now use theme.palette.background.paper, which is #fff in the default theme, so nothing changes outside the dark header. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
NickAkhmetov
force-pushed
the
nickakhmetov/dark-fullscreen-viz-header
branch
from
October 29, 2026 14:54
fd1762d to
2571960
Compare
This was referenced Oct 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When a visualization is in fullscreen and its theme is set to dark, the entity header (which holds the share, theme, workspace and exit-fullscreen buttons) now uses the dark theme too, so it matches the visualization below it. Outside fullscreen the header is not attached to the visualization, so it stays light even when the dark theme is selected.
EntityHeader: wrapped in aThemeProviderthat switches between the existingdarkThemeandlightThemefromjs/theme/theme, the same pairCellPopulationPlotalready uses.WhiteBackground*buttons (shared-styles/buttons): the background was hard-coded to#fff, so in the dark header the light-purple dark-mode icons on the share and exit-fullscreen buttons were almost invisible. They now usetheme.palette.background.paper, which is#fffin the default theme. Nothing changes outside the dark header.Anything that opens from the header also renders dark while the header is dark, such as the share menu, tooltips and the new-workspace dialog.
The header is slightly lighter than Vitessce's
#333. This is MUI's standard dark-mode overlay for raised surfaces (the header Paper haselevation={4}).Stack
Merge in order. Each PR targets the branch of the PR before it, so its diff shows only its own changes.
Design Documentation/Original Tickets
https://hms-dbmi.atlassian.net/browse/CAT-44
Testing
c6a254b2dc2ed46b002500ade163a7cc:pnpm tscand eslint pass. The vitest suites undercomponents/detailPageandshared-styles/buttonspass (206 tests).Screenshots/Video
Light full screen
Dark full screen
Theme applies to share menu:
Theme does not apply to header outside of full screen mode:
Checklist
CHANGELOG-your-feature-name-here.mdis present in the root directory, describing the change(s) in full sentences.Additional Notes
More changes will be stacked on top of this PR.