Repository navigation
Update PHP version requirement to 7.4 and fix incorrect error message - #728
Merged
Merged
Conversation
Co-authored-by: joehoyle <161683+joehoyle@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix required PHP version for S3 Uploads plugin
Update PHP version requirement to 7.4 and fix incorrect error message
Oct 22, 2025
joehoyle
approved these changes
Oct 22, 2025
joehoyle
marked this pull request as ready for review
October 22, 2025 15:36
Rayhatron
approved these changes
Oct 22, 2025
kshitiz-shresth
approved these changes
Nov 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The plugin had a discrepancy between the actual PHP version check and the error message displayed to users:
Additionally, per the agent instructions, the required version needed to be updated from 7.1 to 7.4 to align with the documented requirements in README.md.
Solution
Updated the PHP version requirement from 7.1 to 7.4 in
inc/namespace.php:version_compare(PHP_VERSION, '7.1', '<')toversion_compare(PHP_VERSION, '7.4', '<')Testing
Impact
Users will now see an accurate error message that matches the actual PHP version requirement, eliminating confusion when their environment doesn't meet the minimum PHP 7.4 requirement.
Closes #[issue_number]
Original prompt
Fixes #421
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.