Skip to content

Support default private uploads with Tachyon image resizing #742

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mikelittle wants to merge 2 commits into from
Closed

Support default private uploads with Tachyon image resizing #742

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0c53cac
Support default private uploads with Tachyon image resizing
mikelittle Mar 9, 2026
b6784f8
Fix risky truthy comparison
mikelittle Mar 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 19 additions & 5 deletions inc/class-plugin.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -612,12 +612,26 @@ public function add_s3_signed_params_to_attachment_url( string $url, int $post_i
);

$presigned_url_expires = apply_filters( 's3_uploads_private_attachment_url_expiry', '+6 hours', $post_id );
$query = $this->s3()->createPresignedRequest( $cmd, $presigned_url_expires )->getUri()->getQuery();
$presigned_uri = $this->s3()->createPresignedRequest( $cmd, $presigned_url_expires )->getUri();

$mime_type = get_post_mime_type( $post_id );
$is_image = $mime_type !== false && strpos( $mime_type, 'image/' ) === 0;

if ( $is_image ) {
// For images, keep the original URL host (CDN/site domain) so that
// Tachyon can recognise and process the URL for resizing. Include
// the S3 signing host as an extra parameter so Tachyon's signer
// can set the correct host header when replaying the presigned request.
$query = $presigned_uri->getQuery();
$query .= '&X-Amz-S3-Host=' . rawurlencode( $presigned_uri->getHost() );
$url = strtok( $url, '?' ) . '?' . $query;
} else {
// For non-image files (PDFs, etc.), use the full presigned URL
// pointing directly to the S3 endpoint. This bypasses CloudFront,
// which would reject the signature due to host header mismatch.
$url = (string) $presigned_uri;
}

// The URL could have query params on it already (such as being an already signed URL),
// but query params will mean the S3 signed URL will become corrupt. So, we have to
// remove all query params.
$url = strtok( $url, '?' ) . '?' . $query;
$url = apply_filters( 's3_uploads_presigned_url', $url, $post_id );

return $url;
Expand Down