chore(rt): preserve executor caller locations#4066
Open
punkeel wants to merge 1 commit into
Open
Conversation
Tokio task hooks report the source location of the tokio::spawn call. When runtime executor glue performs that spawn, the recorded location can point at the executor implementation itself. That is technically correct, but it hides the more useful callsite: the code path that asked the executor to create background work. Mark Executor::execute and the HTTP/2 executor forwarding traits with track_caller so task instrumentation can attribute spawned tasks to the caller that requested execution rather than to generic executor forwarding glue.
Author
|
related but independent: hyperium/hyper-util#283 |
Member
|
Will this work? The executor gets turned into a |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tokio task hooks report the source location of the tokio::spawn call. When runtime executor glue performs that spawn, the recorded location can point at the executor implementation itself. That is technically correct, but it hides the more useful callsite: the code path that asked the executor to create background work.
Mark Executor::execute and the HTTP/2 executor forwarding traits with track_caller so task instrumentation can attribute spawned tasks to the caller that requested execution rather than to generic executor forwarding glue.