fix(internals): compare both matrices' column counts in cosineSimilarityMatrix - #1559
Open
Osamaali313 wants to merge 1 commit into
Open
fix(internals): compare both matrices' column counts in cosineSimilarityMatrix#1559Osamaali313 wants to merge 1 commit into
Osamaali313 wants to merge 1 commit into
Conversation
…ityMatrix
The column-count guard compared `matrixA[0]` to itself, so it could never
fire and matrices with differing column counts bypassed validation
(mismatched input returned `[[]]` instead of raising). Compare
`matrixB[0]` as the error message ("Matrices must have the same number of
columns.") intends.
Signed-off-by: Osamaali313 <s.osamaali72@gmail.com>
dosubot
Bot
added
the
size:XS
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request fixes a bug in the cosineSimilarityMatrix function where the column count of matrixA was incorrectly compared to itself instead of matrixB. It also introduces a new test suite to verify this behavior. There are no review comments, so no feedback is provided.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1558
Problem
cosineSimilarityMatrix(typescript/src/internals/helpers/math.ts) validates that both matrices have the same column count, but the guard comparesmatrixA[0]to itself, so it can never fire:Mismatched column counts bypass validation — an empty
matrixBreturns[[]]instead of raising, and other mismatches fall through to the less-specific inner"Vectors must have equal length"error, leaving the intended guard message unreachable.Fix
Compare
matrixB[0](a one-token typo fix), as the error message intends:Tests
Added
math.test.tsasserting that mismatched column counts ([[1,2]]vs[[1,2,3]], and vs[]) throw"Matrices must have the same number of columns.", and that a matching pair still computes similarity. Before the fix the mismatch cases don't raise that error; after, they do.