fix(emitter): preserve unset group id when cloning - #1583
Open
Diwak4r wants to merge 1 commit into
Open
Conversation
Contributor
|
Caution The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased. |
dosubot
Bot
added
the
size:XS
Signed-off-by: Diwak4r <diwak4r.comp@gmail.com>
Diwak4r
force-pushed
the
fix/emitter-clone-none-group-id
branch
from
August 5, 2026 02:12
deb6763 to
9208e93
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Emitter.clone()built the cloned emitter by passingstr(self._group_id). Sincegroup_idisstr | Noneand defaults toNone, an unset group id became the literal string"None"— a truthy, meaningless value that changed event semantics after cloning (e.g.EventMeta.group_idwould suddenly be"None"instead ofNone).The fix passes the group id through unchanged, so a clone of an emitter without a group id keeps
None.Changes
python/beeai_framework/emitter/emitter.py:clone()now passesself._group_iddirectly instead ofstr(self._group_id).python/tests/test_emitter.py: regression tests — cloning preserves both an unset (None) and a set group id.Tests
python -m pytest tests/test_emitter.py→ 18 passed. Dependent clone consumers (lite agent, token/summarize/sliding memory) → 33 passed.ruff checkon changed files → clean.Fixes #1581