Skip to content

Add capability-gated router sensors and diagnostics - #269

Draft
fraviktor wants to merge 1 commit into
iMicknl:mainfrom
fraviktor:enhancement/router-sensors-and-capability-discovery
Draft

Add capability-gated router sensors and diagnostics#269
fraviktor wants to merge 1 commit into
iMicknl:mainfrom
fraviktor:enhancement/router-sensors-and-capability-discovery

Conversation

@fraviktor

Copy link
Copy Markdown

Add gateway, WAN, DSL, and DOCSIS sensors with firmware-aware capability discovery. Improve API session handling and diagnostics,
add English and Hungarian translations,
expand tests and documentation, and provide a privacy-safe router profile collector for contributors.

Add gateway, WAN, DSL, and DOCSIS sensors with firmware-aware capability discovery.
Improve API session handling and diagnostics,
add English and Hungarian translations,
expand tests and documentation, and provide a privacy-safe router profile collector for contributors.
@fraviktor
fraviktor requested a review from iMicknl as a code owner July 19, 2026 06:49
@iMicknl

iMicknl commented Jul 19, 2026

Copy link
Copy Markdown
Owner

Thanks for the many improvements, @fraviktor! It seems to me that part of the code (e.g. the API implementation and docsis code) should live in the underlying python-sagemcom-api. Would you be willing to move parts of your code there?

@fraviktor

Copy link
Copy Markdown
Author

Thanks for the many improvements, @fraviktor! It seems to me that part of the code (e.g. the API implementation and docsis code) should live in the underlying python-sagemcom-api. Would you be willing to move parts of your code there?

Sure, I can do it, you're completely right about separating the layers. Thanks.

@fraviktor
fraviktor marked this pull request as draft July 19, 2026 10:15
@iMicknl

iMicknl commented Jul 19, 2026

Copy link
Copy Markdown
Owner

Thanks @fraviktor! And if you are able to test iMicknl/python-sagemcom-api#386 and iMicknl/python-sagemcom-api#454, that would be appreciated as well.

I don't have my Sagemcom f@st router where I tested this on anymore, and my other one is in bridge mode currently.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants