Skip to content

fix(bigquery): approx_median with where clause duplicates where clause onto quantile argument.#11952

Draft
ssabdb wants to merge 1 commit intoibis-project:mainfrom
ssabdb:bigquery-approx-median
Draft

fix(bigquery): approx_median with where clause duplicates where clause onto quantile argument.#11952
ssabdb wants to merge 1 commit intoibis-project:mainfrom
ssabdb:bigquery-approx-median

Conversation

@ssabdb
Copy link
Copy Markdown
Contributor

@ssabdb ssabdb commented Feb 25, 2026

Description of changes

Prevent duplication of where clause for bigquery onto quantile argument.
Adds system test to test for similar behaviours in other backends.

Issues closed

Resolves #11951

@ssabdb ssabdb marked this pull request as draft February 25, 2026 15:16
@github-actions github-actions Bot added tests Issues or PRs related to tests bigquery The BigQuery backend sql Backends that generate SQL labels Feb 25, 2026
@ssabdb ssabdb changed the title fix(bigquery): ApproxMedian with where clause generates invalid call to ApproxQuantile fix(bigquery): approx_median with where clause duplicates where clause onto quantile argument. Feb 25, 2026
@ssabdb ssabdb force-pushed the bigquery-approx-median branch from 5fc062b to 3368f33 Compare February 25, 2026 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bigquery The BigQuery backend sql Backends that generate SQL tests Issues or PRs related to tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bug: ApproxMedian with where clause applies where clause to the quantile argument

1 participant