Fix multi-thread results and schema validation#613
Draft
pressr-inl wants to merge 12 commits into
Draft
Conversation
Use the parent state's diagram name when deciding whether transition targets are outside the rendered diagram, avoiding the empty child hook state while preserving the state-rename scoping fix. Add a regression test covering same-diagram and cross-diagram transition link icon rendering.
Update the v3.3 schema and interfaces for root objType, templates, multiThreadInfo, distribution parameters, and related top-level validation. Normalize root model objType on UI open/save paths and strip legacy geometry/rootName fields during the v3.3 upgrade, with focused upgrade tests. Add a VandV corpus test that upgrades each TestingFiles/Models fixture through SimulationDAL and validates it against the UI's current schema export, with explicit excluded and expected-failure lists.
pressr-inl
changed the title
Move the Run Application ExeFromPreCode checkbox above the executable location field. Allow ExeFromPreCode actions to defer executable validation until RunExtApp evaluates the preprocessor return string. Add JsonVarExeFromPreCodeTest with a model that returns the executable path from makeInputFileCode.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes two multi-threaded simulation result issues and adds schema-validation coverage for upgraded EMRALD models. The branch preserves watched variable values when combining thread batches for an existing key state, updates EMRALD_Sim so the UI returns to the merged overall results when all threads finish, and tightens the v3.3 model schema/upgrade path so existing model fixtures can be validated consistently.
Related Issue
Fixes #612
Changes Made
ProcessSimBatchinstances instead of only copying values when the key state is new.1.1and1.2.simRuns[0]when the callback has no thread number.objTypehandling for EMRALD models and normalize root/template model objects on UI open/save paths.templates,multiThreadInfo, and strict root validation.geometryand logic-noderootNameduring the v3.3 upgrade.TestingFiles/Modelsfixture through SimulationDAL and validates it against the current UI schema export, with explicit excluded and expected-failure lists.Type of Change
Select the type of change your PR introduces:
Checklist
Please ensure the following are completed:
Screenshots (if applicable)
Not applicable.
Additional Notes
Validation runs:
dotnet build EMRALD_Sim\EMRALD_Sim.csproj --no-restoresucceeded with existing warnings only.npm.cmd run test -- --run src/tests/official/utils/upgrade.test.tsxpassed.npm.cmd run buildpassed.npx.cmd eslint src/utils/Upgrades/v3_3/UpgradeV3_3.ts src/tests/official/utils/upgrade.test.tsx --ext ts,tsx --report-unused-disable-directives --max-warnings 0passed.dotnet test VandV_Testing\Testing.csproj --filter FullyQualifiedName~ModelSchemaUpgradeTestspassed.