Skip to content
Open
Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
318 commits
Select commit Hold shift + click to select a range
1f0a889
Nondimensionalize val-2f
lindsayad Mar 13, 2026
bf6bf19
Remove nondimensionalization doc
lindsayad Mar 23, 2026
b45e478
Simplify dimensionless physics/kernel logic
lindsayad Mar 23, 2026
a1c5994
Clarify trapping_prefactor
lindsayad Mar 23, 2026
f01815d
Robustify physics exception testing after parameter check reordering …
lindsayad Mar 23, 2026
2d7ecdb
Ignore temporary testharness_time files
lindsayad Mar 23, 2026
95aa871
Skip dimensional val-2f
lindsayad Mar 23, 2026
5aab71c
Apply suggestions from code review
Anthony-Bowers08 Mar 24, 2026
6eda1d2
Apply suggestions from code review
Anthony-Bowers08 Mar 24, 2026
5a7781d
Add validation case val-2j: Tritium TDS from Li2TiO3 solid breeder
lin-yang-ly Mar 24, 2026
f2bbd02
Remove extraneous exodus output from csv test
lindsayad Mar 24, 2026
1a8f9d5
Bump abs_tol back up for val-2c delay test
lindsayad Mar 24, 2026
665e9dc
Set bounds to 0 not negative
lindsayad Mar 24, 2026
18bc8ae
Add some postprocessors for viewing concentration magnitudes
lindsayad Mar 24, 2026
cd15982
val-2c delay robustness upgrades
lindsayad Mar 24, 2026
1957cf5
Regold other tests
lindsayad Mar 24, 2026
b89dcb1
Remove parallel restriction from stochastic tools test
lindsayad Mar 24, 2026
ca29026
Remove cruft
lindsayad Mar 24, 2026
cb243bf
Add component-physics example of shared-occupancy use of TrappingNoda…
lindsayad Mar 24, 2026
18f8087
Revert changes made to val-2f tests spec
lindsayad Mar 25, 2026
ec189d5
Add parameters for nondimensionalization val-2f params
lindsayad Mar 25, 2026
e367d06
update model for more accurate performance
lin-yang-ly Mar 25, 2026
01e4e71
Add Bayesian parameter optimization to val-2j validation case
lin-yang-ly Mar 25, 2026
d75e528
update documentation
lin-yang-ly Mar 25, 2026
1e05cb6
Add session logs for val-2j validation case
lin-yang-ly Mar 25, 2026
2f1e06b
make val-2f dimensionless
lindsayad Mar 25, 2026
7549dde
Remove dimensionless directory
lindsayad Mar 26, 2026
167df2a
bump tolerances more
lindsayad Mar 26, 2026
8d41469
Add more sensible testing of the heavy val-2f cases
lindsayad Mar 27, 2026
2c3ef8b
Ask user what conda env is
lindsayad Mar 27, 2026
56f55d2
Remove redundant FactoredCoupledTimeDerivative
lindsayad Mar 27, 2026
c4a7f74
Add missing doc pages
lindsayad Mar 27, 2026
d997bd4
Ignore checkpoint directories
lindsayad Mar 27, 2026
6a4086e
Normalize recent non-ASCII text
lindsayad Mar 27, 2026
af29870
Remove reverted scaling references
lindsayad Mar 27, 2026
d0d473f
Revert unnecessary changes related to variable scaling in SpeciesTrap…
lindsayad Mar 27, 2026
d17213f
Fix ReleasingNodalKernelDimesionless doxygen
lindsayad Mar 27, 2026
e8a6758
Remove unused timeReference
lindsayad Mar 27, 2026
ea81512
Remove unnecessary scripts
lindsayad Mar 27, 2026
09e7cdf
Cosmetic changes to residual return in dimensionless kernels
lindsayad Mar 27, 2026
72cd0b0
Change MooseIndex to make_range
lindsayad Mar 27, 2026
8fb26e4
Further reduce SpeciesTrappingPhysics diff
lindsayad Mar 27, 2026
939966b
Reduce code duplication by creating releasing/trapping nodal kernel b…
lindsayad Mar 27, 2026
c80aa68
Clean up val-2f params file
lindsayad Mar 27, 2026
fd24053
Add missing doxygen
lindsayad Mar 27, 2026
2c0e137
Remove extraneous diff in val-2f.i
lindsayad Mar 27, 2026
aba9b3c
Remove yttrium tests that aren't adding any value
lindsayad Mar 27, 2026
9d47079
Allow brittle yttrium tests to run in recover mode
lindsayad Mar 27, 2026
67ab91b
Switch val-2f RMSPE tests over to RecoverableRunCommand
lindsayad Mar 27, 2026
6572413
Skip non-deterministic acquisition_function in Bayesian JSONDiff test
lin-yang-ly Mar 30, 2026
b4dfb1a
Add comparison script symlink for val-2j documentation figures
lin-yang-ly Mar 30, 2026
43718d5
Reformatted several files to be templatted, adjusted gold file for st…
ke7kto Mar 30, 2026
db0997f
Remove generated image files from repository
ke7kto Mar 30, 2026
3753f7d
Adjust documentation and add a test to ensure the documentation scrip…
ke7kto Mar 30, 2026
a9108ff
Added a dependence on pytables for the generation script test
ke7kto Mar 31, 2026
f71f4db
Add hard-coded files as a backup for where systems do not have access…
ke7kto Mar 31, 2026
556bd1b
Removed HDF5 file and added compressed npz files to store full result…
ke7kto Mar 31, 2026
26101e2
Merge branch 'divertor_monoblock_sensitivity' into HEAD
ke7kto Mar 31, 2026
59cd57f
Re-re-removed saved figures
ke7kto Mar 31, 2026
5d4d10e
Apply suggestions from code review
lin-yang-ly Apr 1, 2026
fdf51b4
Improvement to low pressure fit and corrections to python file
Apr 1, 2026
3c02387
Formatting
Apr 1, 2026
222926a
Modularized files to support more global syntax
ke7kto Apr 1, 2026
08a586a
Formatting source files
Apr 1, 2026
b957d50
Apply suggestions from code review
ke7kto Apr 1, 2026
cc9dc9e
Merge branch 'idaholab:devel' into generic_system_scalar
ke7kto Apr 1, 2026
534463f
Address PR review comments for val-2j validation case
lin-yang-ly Apr 2, 2026
e67e9be
update python format
lin-yang-ly Apr 2, 2026
a3be3fb
Apply suggestions from code review
ke7kto Apr 2, 2026
6abb2cb
Update src/interfacekernels/ADMatInterfaceReactionYHxPCT.C
Anthony-Bowers08 Apr 2, 2026
6c03c81
Update src/interfacekernels/ADMatInterfaceReactionYHxPCT.C
Anthony-Bowers08 Apr 2, 2026
10102f3
Simplify val-2j Bayesian RMSPE and update optimized parameters
lin-yang-ly Apr 2, 2026
bb204af
Remove bayesian_val2j_results from tracking
lin-yang-ly Apr 2, 2026
4d11a94
Modfications to linkage and C. File
Apr 2, 2026
b307479
Apply suggestions from code review, adjust figures, re-gold divertor …
ke7kto Apr 3, 2026
c14da46
Apply suggestions from code review
lin-yang-ly Apr 3, 2026
a16a88f
Apply suggestions from code review. Re-gold based on function name ch…
ke7kto Apr 3, 2026
2e92c64
Add parameter distribution and defect density plots for val-2j
lin-yang-ly Apr 3, 2026
5a48370
update python format
lin-yang-ly Apr 3, 2026
f4b52c8
Apply suggestions from code review: round 1 with maximum of 50
lin-yang-ly Apr 4, 2026
5422deb
Apply suggestions from code review: round 2
lin-yang-ly Apr 4, 2026
58779a4
Apply suggestions from code review
lin-yang-ly Apr 6, 2026
097ca24
Apply suggestions from code review. Move postprocessor documentation …
ke7kto Apr 6, 2026
78273b5
Re-gold divertor monoblock exodus file
ke7kto Apr 6, 2026
59eb1ca
Extend Bayesian optimization to 8 parameters including annihilation
lin-yang-ly Apr 6, 2026
1a7eff9
Apply suggestions from code review
ke7kto Apr 6, 2026
bca3fb0
Apply suggestions from code review
ke7kto Apr 6, 2026
7b21f39
Apply suggestions from code review
lin-yang-ly Apr 6, 2026
134fdf4
Apply suggestions from code review
lin-yang-ly Apr 6, 2026
a997607
update documentation and figures
lin-yang-ly Apr 6, 2026
e28b7c8
quick test only for val-2c
lin-yang-ly Apr 6, 2026
45fa6e0
quick test only for val-2c: update formats
lin-yang-ly Apr 6, 2026
ab9e876
fix physics test case
lin-yang-ly Apr 6, 2026
b0da036
Apply suggestions from code review
ke7kto Apr 7, 2026
c94cbdd
Merge pull request #280 from nsnowISU/divertor_monoblock_sensitivity
simopier Apr 7, 2026
4ef6a28
Apply suggestions from code review
lin-yang-ly Apr 7, 2026
3fdbb02
revert YHx tests
lin-yang-ly Apr 7, 2026
25d0d83
quick test for val-2f:light case
lin-yang-ly Apr 7, 2026
fa79738
quick tests for val-2f:heavy
lin-yang-ly Apr 7, 2026
400bbb3
update YHx failure tests
lin-yang-ly Apr 7, 2026
b510a23
Applied suggestions from code review. Added more documentation to the…
ke7kto Apr 7, 2026
8b854b8
Apply formatting changes
ke7kto Apr 7, 2026
df7679f
update val-2f-heavy tests
lin-yang-ly Apr 7, 2026
1a3e97e
Resolve broken link
ke7kto Apr 7, 2026
4ba1a1d
Change name of scalar kernels directory to match MOOSE, adjust links.
ke7kto Apr 7, 2026
3464267
Adjusted html to .md references in documentation
ke7kto Apr 7, 2026
9a3a2f5
Add the two versions of accuracy for val-2c and val-2f
lin-yang-ly Apr 7, 2026
6699bcf
Apply suggestions from code review
lin-yang-ly Apr 8, 2026
2534b89
Fix broken links per code review
ke7kto Apr 8, 2026
ec9d175
Adjusted tests to properly reference assumptions, and added more deta…
ke7kto Apr 8, 2026
991b650
Add val-2c bdf2 tests: quick test
lin-yang-ly Apr 9, 2026
28fa0d7
val-2f heavy tests: including both schemes quick test
lin-yang-ly Apr 9, 2026
06b6e92
update submodule
lin-yang-ly Apr 9, 2026
4a7917a
update heavy tests rel_err
lin-yang-ly Apr 9, 2026
d6906cb
Apply suggestions from code review
lin-yang-ly Apr 10, 2026
5ce6c4f
Merge pull request #385 from lindsayad/try-some-regularization
simopier Apr 10, 2026
5e8f573
Updating stable moose submodule refs #000
Apr 10, 2026
89c77c1
Merge pull request #334 from ke7kto/generic_system_scalar
simopier Apr 11, 2026
2cc21d5
Add new csv output with temperature, update temperature postprocesso…
simopier Apr 12, 2026
4f51d7e
Add test to track the temperature-focused csv
simopier Apr 12, 2026
00c9ba9
git update gold files
simopier Apr 12, 2026
a297d9d
Update python script
simopier Apr 12, 2026
f7da5e6
Clean python format
simopier Apr 12, 2026
f1b9951
Merge pull request #407 from simopier/val-2f_temperature_history_doc_fix
simopier Apr 13, 2026
a8e84a5
Updating stable moose submodule refs #000
Apr 13, 2026
e9984e3
Apply suggestions from code review
lin-yang-ly Apr 13, 2026
dc93762
Apply suggestions from code review
lin-yang-ly Apr 14, 2026
8edf98f
update the documentation and format
lin-yang-ly Apr 14, 2026
47db332
Updating stable moose submodule refs #000
Apr 14, 2026
81175f4
update O- and F+ symbol
lin-yang-ly Apr 14, 2026
d5b26eb
Apply suggestions from code review
lin-yang-ly Apr 14, 2026
643c36a
Merge pull request #402 from lin-yang-ly/add_validation_solidbreeder
simopier Apr 14, 2026
c0c333e
Updating stable moose submodule refs #000
Apr 15, 2026
953a5f0
Updating stable moose submodule refs #000
Apr 16, 2026
fe081a8
Updating stable moose submodule refs #000
Apr 17, 2026
151b2f3
Updating stable moose submodule refs #000
Apr 18, 2026
f554e9e
Updating stable moose submodule refs #000
Apr 22, 2026
fa700f5
Updating stable moose submodule refs #000
Apr 23, 2026
18718cd
Updating stable moose submodule refs #000
Apr 24, 2026
d936011
Updating stable moose submodule refs #000
Apr 25, 2026
8e2935b
Updating stable moose submodule refs #000
May 1, 2026
be109e0
Updating stable moose submodule refs #000
May 1, 2026
8c628f8
Add val-2k natural oxide baseline
simopier Mar 20, 2026
4d9ee20
Update documentation and reference
simopier Mar 21, 2026
acf1317
Update input files (output trapped concentrations and fix language)
simopier Mar 21, 2026
6ddfcba
Update test requirement
simopier Mar 21, 2026
0238c67
Refine val-2k trap naming and documentation
simopier Mar 21, 2026
9f916af
Add initial deuterium profile output for val-2k
simopier Mar 21, 2026
251d2d5
Digitize experimental data and add as csv files in gold folder
simopier Mar 22, 2026
07f6896
Adopt six-trap val-2f reference in val-2k
simopier Mar 22, 2026
17fe39e
Add header in experimental data files
simopier Mar 22, 2026
0e98f9b
Add initial concentration profile from experiments
simopier Mar 22, 2026
115b6c8
Regold six-trap val-2k baseline
simopier Apr 3, 2026
a27aedc
Fix val-2k documentation links and figure alias
simopier Apr 3, 2026
41c82f8
Update val-2k dimensionless baseline outputs
simopier Apr 17, 2026
e3a23d0
Add experimentally measured temperature history during desorption rat…
simopier Apr 17, 2026
4b26bcf
Add header to csv temperature file
simopier Apr 17, 2026
3f610e7
Import val-2k temperature history from CSV
simopier Apr 17, 2026
6befa48
Add val-2k inventory history figure
simopier Apr 17, 2026
9fefb26
Align val-2k inventory colors with val-2f
simopier Apr 17, 2026
734d76a
Reduce val-2k Exodus output frequency
simopier Apr 17, 2026
b770b76
Update format of python script
simopier Apr 18, 2026
f6490cb
Add implicit_euler tests for stability on CIVET
simopier Apr 18, 2026
d83f381
Fix documentation
simopier Apr 18, 2026
3802ae0
regold tests
simopier Apr 18, 2026
7deb99a
General clean up as overal review of validation case.
simopier Apr 18, 2026
04f2b59
Re-gold
simopier Apr 18, 2026
39c4727
Extend val-2k sample history and profile coverage
simopier Apr 18, 2026
ae9627a
Small clean up
simopier Apr 18, 2026
ed5d566
Move val-2k refinement to exposed surface
simopier Apr 21, 2026
8179653
Add val-2k 5 nm oxide companion case; both simulations currently prod…
simopier Apr 22, 2026
884a139
Add D2O surface release channels to val-2k
simopier Apr 22, 2026
5e8aec5
val-2k: add deuterium mass conservation diagnostics
simopier Apr 23, 2026
ab7cb36
val-2k: switch 5 nm companion case to oxygen field
simopier Apr 25, 2026
ec9fab4
val-2k: regold exodus outputs after test run
simopier Apr 25, 2026
6f6f174
val-2k: track oxygen conservation in oxide case
simopier Apr 26, 2026
f728772
Add json file
simopier Apr 26, 2026
5b3e2ac
val-2k: consolidate oxygen-field inputs
simopier Apr 26, 2026
e5057c9
val-2k: rename oxygen-field inputs
simopier Apr 26, 2026
8f20b17
Input file clean up
simopier Apr 26, 2026
5b4b326
val-2k: restyle TDS comparison figure
simopier Apr 26, 2026
a287718
Python format
simopier Apr 26, 2026
9c520a5
val-2k: add 10 nm and 15 nm oxide cases
simopier Apr 26, 2026
0318c17
val-2k: retune D2O release parameters
simopier Apr 26, 2026
668c104
Update val-2k profile artifacts and docs
simopier Apr 26, 2026
3fd8f22
Python format
simopier Apr 26, 2026
20bc8cc
Add profile as gold file.
simopier Apr 29, 2026
217f3cd
Add val-2k oxygen inventory plot script
simopier Apr 29, 2026
9250213
Update val-2k outputs and documentation
simopier Apr 29, 2026
6dea12e
Update val-2k mesh and regold outputs
simopier May 1, 2026
75f998f
Add val-2k recombination-rate figure
simopier May 1, 2026
ce938e0
Hand calibration to better match the ttrends of the experimental data
simopier May 2, 2026
95cfa22
Update val-2k documentation for latest calibration
simopier May 2, 2026
ca37bf6
Update val-2k TDS figure set
simopier May 2, 2026
35a2cd6
review and Update of the documentation.
simopier May 2, 2026
f9f80cb
Add light test for val-2k
simopier May 2, 2026
f5423b9
Error clean up and updates.
simopier May 2, 2026
d24c73b
Python format
simopier May 2, 2026
5ca15a8
Update val-2k equation presentation
simopier May 2, 2026
4e1a9fe
Update val-2k natural-oxide case and docs
simopier May 2, 2026
ac34363
Add light test gold file
simopier May 2, 2026
99b2c49
Update documentation
simopier May 2, 2026
a145400
regold files for new oxide layer thickness.
simopier May 2, 2026
d07f6a2
Update documentation
simopier May 2, 2026
1580af4
Update tolerances for heavy tests on sensitive outputs
simopier May 3, 2026
c6a1241
Update test tolerance, update documentation, and regold exodus for lo…
simopier May 3, 2026
b2941de
Clean up documentation, add custom exodus tolerances, and loosen 10 n…
simopier May 3, 2026
664aef6
Update doc and exodiff tolerance for oxygen_physical
simopier May 3, 2026
5f884b8
Update label for 1 nm oxide to make figures more consistent in size
simopier May 3, 2026
3f2f3aa
Refine val-2k single-case TDS styling
simopier May 3, 2026
d9f1e61
Further loosen oxygen tolerances for exodus test
simopier May 3, 2026
345489a
Apply suggestions from code review
simopier May 5, 2026
4a2e176
Apply suggestions from code review
simopier May 6, 2026
8fb096a
Address review comments, update documentation, clarify things, and st…
simopier May 6, 2026
392f3ca
Refine val-2k figure script and input headers
simopier May 6, 2026
c02b6c1
Move profile csvs to the direct gold folder rather than under profile…
simopier May 6, 2026
84d91a6
Use subscripts in val-2k TDS labels
simopier May 6, 2026
885723b
Update documentation for grammar improvement
simopier May 6, 2026
0454246
Python format
simopier May 6, 2026
f930d16
Apply suggestions from code review
simopier May 7, 2026
85a0263
remove un-needed folder
simopier May 7, 2026
c9b8c7f
Updating stable moose submodule refs #000
May 7, 2026
15d2be4
Merge pull request #409 from simopier/TMAP8_val-2k
simopier May 7, 2026
c0d86a1
Remove empty slide
simopier May 10, 2026
6f9f45c
Merge pull request #413 from simopier/TMAP8_Workshop
simopier May 10, 2026
de04f8e
Updating stable moose submodule refs #000
May 11, 2026
f8b31bf
Fix typos in the docs (#414)
nmnobre May 11, 2026
68faf48
Updating comparison file with corrected steady state analytical solut…
May 11, 2026
5b8a6e7
Merge pull request #414 from nmnobre/typos
cticenhour May 11, 2026
d0fab02
Updating documentation to reflect changes to the steady state analyti…
May 11, 2026
61d2774
Updating stable moose submodule refs #000
May 12, 2026
f952c4e
Updating stable moose submodule refs #000
May 15, 2026
87c7d47
Updating with edits requested by reviewer (Lin Yang, @lin-yang-ly)
May 18, 2026
ad8b07e
Updating stable moose submodule refs #000
May 20, 2026
bebd1a0
Update doc/content/verification_and_validation/ver-1e.md
cjsilsby May 26, 2026
ec04130
Merge pull request #416 from cjsilsby/analytical_1e
simopier May 27, 2026
2f64bdd
Including full ranges PCT modelling for YHx
May 30, 2026
af8ae3a
Modifications, reformatting, and cleaning YHX #Ref 262
Mar 12, 2026
b5399ca
Ref. #261
Mar 18, 2026
1a0c67f
Appling patches to python and C files
Mar 18, 2026
1cec720
Apply suggestions from code review
Anthony-Bowers08 Mar 24, 2026
0685813
Apply suggestions from code review
Anthony-Bowers08 Mar 24, 2026
84774e1
Improvement to low pressure fit and corrections to python file
Apr 1, 2026
3c6984e
Formatting
Apr 1, 2026
8b1bc23
Formatting source files
Apr 1, 2026
cd9dbba
Update src/interfacekernels/ADMatInterfaceReactionYHxPCT.C
Anthony-Bowers08 Apr 2, 2026
491e938
Update src/interfacekernels/ADMatInterfaceReactionYHxPCT.C
Anthony-Bowers08 Apr 2, 2026
4c67aa5
Modfications to linkage and C. File
Apr 2, 2026
a9e9456
Including full ranges PCT modelling for YHx
May 30, 2026
aa036a6
Merge branch 'yttrium_hydride_lowpressure' of github.com:Anthony-Bowe…
May 30, 2026
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 16 additions & 10 deletions doc/content/source/interfacekernels/ADMatInterfaceReactionYHxPCT.md
Original file line number Diff line number Diff line change
Expand Up @@ -16,13 +16,20 @@ $K_b$ and $K_f$ are the backward and forward surface reaction rate in 1/s, respe
$f_{at}(T,P)$ is the composition in atomic fraction of H in YHx given a gas temperature $T$ and gas pressure $P$,
and $\rho$ is the yttrium atomic density in mol/m$^3$.

[YHx_PCT_fit_2D] shows the data used in this interface kernel. The experimental data originates from [!cite](Lundin_1962), and the fit is from [!cite](Matthews2021SWIFT).
[YHx_PCT_Data] shows the data used in this interface kernel. The experimental data originates from [!cite](Lundin_1962).
The [YHx_PCT_fit_2D] shows high and low pressure fit with the high pressure fit from [!cite](Matthews2021SWIFT) and the low-pressure is a newly fitted curve.
Comment thread
Anthony-Bowers08 marked this conversation as resolved.
Outdated

!media comparison_YHx_PCT.py

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use the same colors as for the following figure. You use the same type of color palette, but it would be easier for the reader if you used the same color for the same temperature in both figures.

image_name=YHx_PCT_Data.png
style=width:80%;margin-bottom:2%;margin-left:auto;margin-right:auto
id=YHx_PCT_Data
caption=PCT data for YHx from [!cite](Lundin_1962).
Comment thread
Anthony-Bowers08 marked this conversation as resolved.
Outdated

!media comparison_YHx_PCT.py

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do you cut the low pressure data at an atomic fraction of 0.5? It can/should go further than that, especially for higher temperatures.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The fit becomes severely offset to the PCT data for values above 0.5. Please schedule a meeting to discuss if interested.

image_name=YHx_PCT_fit_2D.png
style=width:80%;margin-bottom:2%;margin-left:auto;margin-right:auto
id=YHx_PCT_fit_2D
caption=PCT data for YHx from [!cite](Lundin_1962) with fits from [!cite](Matthews2021SWIFT) implemented in TMAP8, and test results.
caption=PCT data for YHx from [!cite](Lundin_1962) with high pressure fits from [!cite](Matthews2021SWIFT) implemented in TMAP8, and test results.
Comment thread
Anthony-Bowers08 marked this conversation as resolved.
Outdated

The plateau representing phase transition is captured as [!citep](Matthews2021SWIFT):
\begin{equation} \label{eq:pressure_plateau}
Expand All @@ -37,16 +44,15 @@ This fit is shown in [YHx_PCT_plateau_pressure_fit].
id=YHx_PCT_plateau_pressure_fit
caption=Fit phase transition region as pressure as a function of temperature.

The model currently only captures the high pressure region of the data, i.e., for pressure and temperatures above the plateau.
In this region, the atomic fraction $f_{at}$ is determined as [!citep](Matthews2021SWIFT):
\begin{equation} \label{eq:atomic_fraction}
In the high pressure region, the atomic fraction $f_{at}$ is determined as [!citep](Matthews2021SWIFT):
\begin{equation}
f_{at}(T,P) = 2-\left[1+\exp(21.6 -0.0225 T + (-0.0445 + 7.18 \times 10^{-4} T) (\log\left(P - P_{lim}(T)\right)))\right]^{-1},
\end{equation}
where $P$ is the hydrogen partial pressure in Pa. This fit is plotted in [YHx_PCT_fit_2D].
where $P$ is the hydrogen partial pressure in Pa. While in the low pressure region, the atomic fraction $f_{at}$ is determined as:
Comment thread
Anthony-Bowers08 marked this conversation as resolved.
Outdated
\begin{equation}
f_{at}(T,P) = 0.5-\left[0.001+\exp(-89.75 + 0.0975 T + (1.20 - 4.41 \times 10^{-3} T) (\log\left(P_{lim}(T) - P\right)))\right]^{-1},

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you cutting the low pressure region to an atomic fraction of 0.5 because of the 0.5 at the start of this expression?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you are referring to the cut off in the .C file, then yes.

\end{equation}
Comment thread
Anthony-Bowers08 marked this conversation as resolved.

Comment thread
Anthony-Bowers08 marked this conversation as resolved.
The [!param](/InterfaceKernels/ADMatInterfaceReactionYHxPCT/silence_warnings) option can be used to dictate how TMAP8 reacts when the pressure gets out of bounds.
If `silence_warnings = false`, which is the default behavior, then TMAP8 will print a warning stating that the pressure and temperature are outside the bounds of the atomic fraction correlation.
If `silence_warnings = true`, then TMAP8 will let the simulation continue without issuing any warnings.

## Test

Expand All @@ -59,7 +65,7 @@ To model the interface, the input file employs the [InterfaceDiffusion.md] objec
\end{equation}
where $\rho$ is the yttrium atomic density.

The results of the test for ($T$, $P$) = (1173.15 K, $1 \times 10^{3}$ Pa), (1173.15 K, $1 \times 10^{4}$ Pa), (1173.15 K, $5 \times 10^{4}$ Pa), and(1473.15 K, $5 \times 10^{4}$ Pa) are shown in [YHx_PCT_fit_2D] and show good agreement with [eq:atomic_fraction].
The results of the high pressure test for ($T$, $P$) = (1173.15 K, $1 \times 10^{3}$ Pa), (1173.15 K, $1 \times 10^{4}$ Pa), (1173.15 K, $5 \times 10^{4}$ Pa), and(1473.15 K, $5 \times 10^{4}$ Pa). While the low pressure test for ($T$, $P$) = (1473.15 K, $3 \times 10^{3}$ Pa), (1273.15 K, $3 \times 10^{2}$ Pa), (1573.15 K, $5 \times 10^{3}$ Pa), and(1573.15 K, $6 \times 10^{2}$ Pa).
Comment thread
Anthony-Bowers08 marked this conversation as resolved.
Outdated

## Example Input File Syntax

Expand Down
1 change: 1 addition & 0 deletions include/interfacekernels/ADMatInterfaceReactionYHxPCT.h
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@
* (1962) 838–5.
* The fits are from Matthews et al., Metal Hydride Simulations Using SWIFT, LANL technical report
* LA-UR-21-27538, 2021.

Comment thread
Anthony-Bowers08 marked this conversation as resolved.
Outdated
*/

class ADMatInterfaceReactionYHxPCT : public ADInterfaceKernel
Expand Down
51 changes: 39 additions & 12 deletions src/interfacekernels/ADMatInterfaceReactionYHxPCT.C
Original file line number Diff line number Diff line change
@@ -1,10 +1,10 @@
/************************************************************/
/*************************************************************/
Comment thread
Anthony-Bowers08 marked this conversation as resolved.
Outdated
/* DO NOT MODIFY THIS HEADER */
/* TMAP8: Tritium Migration Analysis Program, Version 8 */
/* */
/* Copyright 2021 - 2025 Battelle Energy Alliance, LLC */
/* ALL RIGHTS RESERVED */
/************************************************************/
/*************************************************************/
Comment thread
Anthony-Bowers08 marked this conversation as resolved.
Outdated

#include "ADMatInterfaceReactionYHxPCT.h"

Expand Down Expand Up @@ -53,30 +53,57 @@ ADMatInterfaceReactionYHxPCT::computeQpResidual(Moose::DGResidualType type)
using std::pow;
ADReal r = 0;

// tolerance for the pressure being closed to the plateau region
const Real tolerance = 10; // Pa

// Calculate the equilibrium concentration value based on PCT curve
// (/2 because two atoms for a molecule) (pressure in Pa)
// (2 because two atoms for a molecule
Comment thread
Anthony-Bowers08 marked this conversation as resolved.
Outdated
auto neighbor_pressure =
PhysicalConstants::ideal_gas_constant * _neighbor_temperature[_qp] * _neighbor_value[_qp] / 2;

// Calculate the value of the pressures for the phase transition plateau (pressure in Pa)
// Plateau/limit pressure (Pa)
Comment thread
Anthony-Bowers08 marked this conversation as resolved.
Outdated
auto limit_pressure = exp(-26.1 + 3.88e-2 * _neighbor_temperature[_qp] -
9.7e-6 * Utility::pow<2>(_neighbor_temperature[_qp]));

// return warning if the PCT curves is used out of bounds (pressure in Pa)
if (!_silence_warnings && ((neighbor_pressure < limit_pressure) || (neighbor_pressure > 1.e6)))
// define atomic fraction variable
ADReal atomic_fraction = 0.0;

Comment thread
Anthony-Bowers08 marked this conversation as resolved.
if (!_silence_warnings && ((neighbor_pressure < 0.011) || (neighbor_pressure > 1.e6)))
Comment thread
simopier marked this conversation as resolved.
Outdated
mooseDoOnce(mooseWarning("In YHxPCT: pressure ",
neighbor_pressure,
"Pa and temperature ",
_neighbor_temperature[_qp],
"K are outside the bounds of the atomic fraction correlation. See "
"documentation for YHxPCT material."));

// Calculate the atomic fraction based on the PCT curve
auto atomic_fraction =
2. - pow(1. + exp(21.6 - 0.0225 * _neighbor_temperature[_qp] +
(-0.0445 + 7.18e-4 * _neighbor_temperature[_qp]) *
(log(max(neighbor_pressure - limit_pressure, 1e-10)))),
-1);
if (neighbor_pressure > limit_pressure && abs(neighbor_pressure - limit_pressure) < tolerance)
Comment thread
Anthony-Bowers08 marked this conversation as resolved.
Outdated
{
// High pressure region, near limit
atomic_fraction = 0.5;

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you sure you want it to be set to 0,5 here? coming from the high pressure region, why would you pick 0.5 here?

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This comment still holds.

}
else if (neighbor_pressure > limit_pressure)
{
// High pressure region (far enough from plateau)
atomic_fraction = 2. - pow(1. + exp(21.6 - 0.0225 * _neighbor_temperature[_qp] +
(-0.0445 + 7.18e-4 * _neighbor_temperature[_qp]) *
log(max(neighbor_pressure - limit_pressure, 1e-10))),
-1);
}
else if ((neighbor_pressure < limit_pressure) &&
(abs(neighbor_pressure - limit_pressure) < tolerance))
{
// Low pressure region, near limit
atomic_fraction = 1.0;
}
else if (neighbor_pressure < limit_pressure)
{
// Low pressure region (far enough from plateau)
atomic_fraction =
0.5 - pow(0.001 + exp(-8.97e01 + 9.75e-2 * _neighbor_temperature[_qp] +

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

documentation lists 8.975e01 instead of 8.97e01.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Completed (This is for me, ignore PC)

(1.20 - 4.41e-3 * _neighbor_temperature[_qp]) *
log(max(limit_pressure - neighbor_pressure, 1e-10))),
-1);
}

// Convert to concentration
auto _surface_equilibrium_concentration = atomic_fraction * _density[_qp];
Expand Down
37 changes: 17 additions & 20 deletions test/tests/yttrium_hydrogen_system/PCT_data/1000.csv
Original file line number Diff line number Diff line change
Expand Up @@ -14,22 +14,22 @@ Atom Ratio (-),Partial Pressure (mm Hg)
0.5003812713236798, 9.661704954868043
0.5248298036256153, 11.417576632627881
0.5468295520651542, 13.19528722851941
0.5663805166422968, 14.913806704747937
0.5980103139789005, 14.90591251598713
0.6345062339826738, 14.896809028798605
0.6783091992516077, 15.052940279008315
0.7196633806581451, 14.875589174160138
0.7513010392591545, 15.034559330727195
0.7877969592629279, 15.025377275076085
0.8194267565995315, 15.01742402968676
0.8461825700045595, 14.84411833474094
0.8778123673411633, 14.836261033487002
0.9143161486093423, 14.993589543517993
0.943512884612361, 14.986263468670607
0.9775757432825496, 14.977720905469436
1.011638601952738, 14.969183211753325
1.0432683992893417, 14.961259711053058
1.0481345219565115, 14.960041083256012
0.5663805166422968, 14.836261033487002
0.5980103139789005, 14.84411833474094
0.6345062339826738, 14.875589174160138
0.6783091992516077, 14.896809028798605
0.7196633806581451, 14.90591251598713
0.7513010392591545, 14.913806704747937
0.7877969592629279, 14.960041083256012
0.8194267565995315, 14.961259711053058
0.8461825700045595, 14.969183211753325
0.8778123673411633, 14.977720905469436
0.9143161486093423, 14.986263468670607
0.943512884612361, 14.993589543517993
0.9775757432825496, 15.01742402968676
1.011638601952738, 15.025377275076085
1.0432683992893417, 15.034559330727195
1.0481345219565115, 15.052940279008315
1.0798114868795496, 15.987540632145134
1.1212285584013335, 17.27453057131089
1.1455906167948053, 18.05573840599329
Expand Down Expand Up @@ -62,7 +62,4 @@ Atom Ratio (-),Partial Pressure (mm Hg)
1.9119538386554096, 524.2537323663885
1.9291896608650534, 700.5286849730287
1.9365517349810544, 765.8515855528643
0.5712466393094666, 14.912591942103536
0.5761127619766364, 14.911377278404247
1.0384022766221719, 14.962478438118127
1.0651895350848233, 15.464944999627683

30 changes: 13 additions & 17 deletions test/tests/yttrium_hydrogen_system/PCT_data/1050.csv
Original file line number Diff line number Diff line change
Expand Up @@ -26,20 +26,20 @@ Atom Ratio (-),Partial Pressure (mm Hg)
0.5399077087558763, 22.547710391605136
0.5594586733330189, 25.48426484330247
0.5716790088517838, 27.54919779324486
0.5790017766457557, 28.483627797847237
0.5960332059808501, 28.475508433196833
0.6325291259846234, 28.45811758738781
0.6763242299891515, 28.437262591711786
0.7176862726600947, 28.417580240273985
0.761473515400217, 28.08162556388147
0.7931111740012262, 28.38172395731534
0.5790017766457557, 28.021074736663728
0.5960332059808501, 28.08162556388147
0.6325291259846234, 28.276729535554693
0.6763242299891515, 28.282488362300167
0.7176862726600947, 28.298619317459913
0.761473515400217, 28.317065960779317
0.7931111740012262, 28.351685833131302
0.82474097133783, 28.366700919219717
0.8563707686744337, 28.351685833131302
0.8904257660802164, 28.021074736663728
0.9293626086819804, 28.317065960779317
0.9682915900193385, 28.298619317459913
1.0023544486895273, 28.282488362300167
1.0145197553574516, 28.276729535554693
0.8563707686744337, 28.38172395731534
0.8904257660802164, 28.417580240273985
0.9293626086819804, 28.437262591711786
0.9682915900193385, 28.45811758738781
1.0023544486895273, 28.475508433196833
1.0145197553574516, 28.483627797847237
1.0388975362797352, 30.222550814781602
1.068133578604783, 31.9411986552508
1.102243604861406, 34.13362375347649
Expand Down Expand Up @@ -72,7 +72,3 @@ Atom Ratio (-),Partial Pressure (mm Hg)
1.8658671760766001, 641.3779884427049
1.878111095388583, 716.9523738731084
1.8854653082401773, 775.1085545978324
0.5741277927141802, 28.169828844760538
0.5838678993129256, 28.4813077431683
1.0096536326902819, 28.279032925527343
1.0267086458185937, 29.233455068878477
25 changes: 10 additions & 15 deletions test/tests/yttrium_hydrogen_system/PCT_data/1100.csv
Original file line number Diff line number Diff line change
Expand Up @@ -30,16 +30,16 @@ Atom Ratio (-),Partial Pressure (mm Hg)
0.5427259720453438, 38.954870591321125
0.5573950914265051, 43.05998403229226
0.5769460560036477, 48.668003010889905
0.5916151753848089, 53.796698608449915
0.635410279389337, 53.75727471073713
0.684071506061035, 53.71350426360323
0.7278666100655631, 53.67414133329971
0.7619294687357515, 53.643545665102174
0.8154568180746191, 53.59550199070021
0.8714172287470716, 53.54532051887158
0.91034621008443, 53.510439382866785
0.9444090687546185, 53.479937029074186
0.976038866091222, 53.45162898363805
0.5916151753848089, 53.45162898363805
0.635410279389337, 53.479937029074186
0.684071506061035, 53.510439382866785
0.7278666100655631, 53.54532051887158
0.7619294687357515, 53.59550199070021
0.8154568180746191, 53.643545665102174
0.8714172287470716, 53.67414133329971
0.91034621008443, 53.71350426360323
0.9444090687546185, 53.75727471073713
0.976038866091222, 53.796698608449915
1.002841847082685, 56.49353181939432
1.0345188120057232, 60.373673467170235
1.0661957769287613, 64.52031463660713
Expand Down Expand Up @@ -71,8 +71,3 @@ Atom Ratio (-),Partial Pressure (mm Hg)
1.7757810166187131, 587.4849499543402
1.7977729037938461, 671.4214149099407
1.8173395908998007, 775.9929751479735
0.5867254689244219, 52.029732360862724
0.5964812980519788, 53.792316747993
0.6013474207191485, 53.787935244448335
0.9711727434240522, 53.45598309206024
0.9882277565523638, 55.260131561070004
26 changes: 10 additions & 16 deletions test/tests/yttrium_hydrogen_system/PCT_data/1150.csv
Original file line number Diff line number Diff line change
Expand Up @@ -30,17 +30,17 @@ Atom Ratio (-),Partial Pressure (mm Hg)
0.5455442353348113, 67.30093284112601
0.5699770451079351, 77.77648448455122
0.5870870870870871, 86.93390519466453
0.6041892678018332, 96.0911962129842
0.6504174331399463, 96.01686695668666
0.6917794758108895, 95.9504105699897
0.7307084571482477, 95.88790540075408
0.7672043771520212, 95.82934378519286
0.8037081584202002, 96.8455491378044
0.837763155825983, 95.71622605709229
0.8791251984969264, 95.64997775370932
0.9229203025014545, 95.57988246837148
0.6041892678018332, 95.57988246837148
0.6504174331399463, 95.64997775370932
0.6917794758108895, 95.71622605709229
0.7307084571482477, 95.82934378519286
0.7672043771520212, 95.88790540075408
0.8037081584202002, 95.9504105699897
0.837763155825983, 96.01686695668666
0.8791251984969264, 96.0911962129842
0.9229203025014545, 96.60524527949393
0.9423926544345393, 96.62098462559449
0.9521248997688787, 96.60524527949393
0.9521248997688787, 96.8455491378044
0.9813688033583321, 103.24458202382107
1.0106127069477855, 110.34021689437361
1.0398644718016445, 119.2468362939784
Expand All @@ -62,9 +62,3 @@ Atom Ratio (-),Partial Pressure (mm Hg)
1.5738054808735438, 563.7401394031765
1.6006477681870352, 630.0123853764603
1.6323640394321024, 711.9185511096462
1.6470095750200464, 761.0321426711316
0.5968665000078613, 92.9388415495683
0.611488451802588, 96.0794561903707
0.6236537584705124, 96.05989267336636
0.9472587771017089, 96.61311463202999
0.9667468515636057, 99.86975603349624
Loading