Full ranged ZrCoHx PCT modelling capabilities#420
Open
Anthony-Bowers08 wants to merge 4 commits into
Open
Conversation
simopier
requested changes
Jun 3, 2026
simopier
left a comment
simopier
left a comment
Collaborator
There was a problem hiding this comment.
This is a partial review, not a full detailed one.
Please address these things first.
You are also missing an issue number in your commit history:
##########################################################################
ERROR: Your patch does not contain a valid ticket reference! (i.e. #1234)
Merge branch 'ZrCoHx_FullRange_PCT_Modelling' of https://github.com/Anthony-Bowers08/TMAP8 into test
Full ranged ZrCoHx PCT modelling capabilities Ref. 261
##########################################################################
Collaborator
|
This PR is still failing due to: |
|
Job Documentation, step Sync to remote on e454875 wanted to post the following: View the site here This comment will be updated on new commits. |
Anthony-Bowers08
force-pushed
the
ZrCoHx_FullRange_PCT_Modelling
branch
from
6e56f25 to
f898b6b
Compare
Anthony-Bowers08
force-pushed
the
ZrCoHx_FullRange_PCT_Modelling
branch
from
f898b6b to
681717b
Compare
Anthony-Bowers08
force-pushed
the
ZrCoHx_FullRange_PCT_Modelling
branch
from
da77422 to
f898b6b
Compare
lin-yang-ly
force-pushed
the
ZrCoHx_FullRange_PCT_Modelling
branch
from
f898b6b to
f1d8f2f
Compare
lin-yang-ly
changed the title
|
Job Build test summary, step Build test summary on e454875 wanted to post the following: Test summaryCompared against 5dd63d1 in job civet.inl.gov/job/3908047. Removed tests
Added tests
|
simopier
requested changes
Jun 22, 2026
simopier
left a comment
simopier
left a comment
Collaborator
There was a problem hiding this comment.
Getting closer too! Let me know if you have any questions about these comments and suggestions.
Comment on lines
+61
to
+63
| return 2.7 - 1.4529 * ( | ||
| 1.0 | ||
| + np.exp(6.5726 - 2.2087e-02 * T + (6.5206e-01 - 1.1738e-05 * T) * np.log(arg)) |
Collaborator
There was a problem hiding this comment.
Suggested change
| return 2.7 - 1.4529 * ( | |
| 1.0 | |
| + np.exp(6.5726 - 2.2087e-02 * T + (6.5206e-01 - 1.1738e-05 * T) * np.log(arg)) | |
| return 2.7 - 1.45 * ( | |
| 1.0 | |
| + np.exp(6.57 - 2.21e-02 * T + (6.52e-01 - 1.17e-05 * T) * np.log(arg)) |
| plt.yscale("log") | ||
| plt.xlabel("Atom Ratio (-)") | ||
| plt.ylabel("Partial Pressure (Pa)") | ||
| plt.ylabel("Pressure (Pa)") |
Collaborator
There was a problem hiding this comment.
Suggested change
| plt.ylabel("Pressure (Pa)") | |
| plt.ylabel("Partial Pressure (Pa)") |
I think you should keep the partial here.
Comment on lines
+132
to
+134
| p = os.path.join(gold_dir, f) | ||
| if os.path.exists(p): | ||
| tmap_low[f] = pd.read_csv(p) |
Collaborator
There was a problem hiding this comment.
Suggested change
| p = os.path.join(gold_dir, f) | |
| if os.path.exists(p): | |
| tmap_low[f] = pd.read_csv(p) | |
| path = os.path.join(gold_dir, f) | |
| if os.path.exists(path): | |
| tmap_low[f] = pd.read_csv(path) |
Comment on lines
+138
to
+140
| p = os.path.join(gold_dir, f) | ||
| if os.path.exists(p): | ||
| tmap_high[f] = pd.read_csv(p) |
Collaborator
There was a problem hiding this comment.
Suggested change
| p = os.path.join(gold_dir, f) | |
| if os.path.exists(p): | |
| tmap_high[f] = pd.read_csv(p) | |
| path = os.path.join(gold_dir, f) | |
| if os.path.exists(path): | |
| tmap_high[f] = pd.read_csv(path) |
Comment on lines
+251
to
+252
| • Plots exp scatter vs TMAP8 dashed | ||
| • Calculates MAPE on overlapping atomic‑ratio range |
Collaborator
There was a problem hiding this comment.
Suggested change
| • Plots exp scatter vs TMAP8 dashed | |
| • Calculates MAPE on overlapping atomic‑ratio range | |
| - Plots exp scatter vs TMAP8 dashed | |
| - Calculates MAPE on overlapping atomic‑ratio range |
Co-authored-by: Pierre-Clement Simon <pierreclement.simon@gmail.com>
|
Job Precheck, step Format Check Clang on 7dee5d8 wanted to post the following: Your code requires style changes. A patch was auto generated and copied here
Alternatively, with your repository up to date and in the top level of your repository:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ref. #261
Reason
Design
Full range ZrCo PCT modelling capabilities
Impact
Full range ZrCo PCT modelling capabilities