Add Verification cases ver-1n and ver-1o#428
Conversation
- Add tests files - Add input files - Add python scripts - Add documentations Ref. idaholab#426
|
Job Documentation, step Sync to remote on ae94322 wanted to post the following: View the site here This comment will be updated on new commits. |
|
Job Precheck on 10ef7ea : invalidated by @lin-yang-ly |
|
@simopier, the PR is ready for your review. Current failure in Test Heavy is because of "divertor_monoblock". |
simopier
left a comment
simopier
left a comment
There was a problem hiding this comment.
Looks great to me, I just have some relatively minor comments throughout.
| \begin{equation} | ||
| \label{eq:Nernst_Plank} | ||
| \frac{\partial C}{\partial t} | ||
| = | ||
| \frac{\partial}{\partial x}\left(D\frac{\partial C}{\partial x}\right) | ||
| + | ||
| \frac{\partial}{\partial x}\left(\frac{CDF}{RT}\frac{\partial \phi}{\partial x}\right), | ||
| \end{equation} |
There was a problem hiding this comment.
Update to a more general expression (not only for x axis).
| R = 8.31446261815324 # J/mol/K | ||
| eV_to_J = 1.602176634e-19 # eV/J | ||
| N_a = 6.02214076e23 # at/mol | ||
| q = 1.602176634e-19 # C quantity of charge | ||
| F = N_a * q |
There was a problem hiding this comment.
Look at what I have done for val-2k. You can actually read these values from the input file directly. This way, they are defined once and always consistent.
| HALF_LENGTH = 5.0e-3 # m, half-slab thickness (symmetry domain) | ||
| FULL_LENGTH = 10.0e-3 # m, full PCC slab thickness | ||
| SURFACE_TEMPERATURE = 773.0 # K, prescribed left-surface temperature | ||
| THERMAL_CONDUCTIVITY = 0.014 # W/m/K | ||
| SIGMA_REF = 1e-03 # S/m, electrical conductivity | ||
| VOLTAGE_TOTAL = 20.0 # V, voltage drop across the full 10 mm slab | ||
| DENSITY = 6.154e3 # kg/m^3 | ||
| SPECIFIC_HEAT_MOLAR = 120.0 # J/mol/K | ||
| MOLAR_MASS_BCY20 = 283.42e-3 # kg/mol |
There was a problem hiding this comment.
Look at what I have done for val-2k. You can actually read these values from the input file directly. This way, they are defined once and always consistent.
There was a problem hiding this comment.
This exodus is small, that's good!
| Temperature = 773 # K | ||
| Pressure_high = 100 # Pa | ||
| V = 20 # V | ||
| L = 10e-3 # m | ||
| diffusivity = ( | ||
| np.sqrt(3) * 1.41e-6 * np.exp(-0.74 * eV_to_J * N_a / R / Temperature) | ||
| ) # m^2/s | ||
| solubility = 1.06 * N_a * np.exp(-7726.21 / R / Temperature) # atom/m^3/Pa^0.5 |
There was a problem hiding this comment.
Same here about extracting values from input file. Make sure to check both python script for opportunities to do that.
Co-authored-by: Pierre-Clement Simon <pierreclement.simon@gmail.com>
|
Job Precheck, step Python: black format on 6676f7d wanted to post the following: Python black formattingYour code requires style changes. A patch was generated and copied here. You can directly apply the patch by running the following at the top level of your repository: Alternatively, you can run the following at the top level of your repository: |
|
Job Build test summary, step Build test summary on ae94322 wanted to post the following: Test summaryCompared against c35f84b in job civet.inl.gov/job/3943508. Added tests
|
3 participants
Ref. Add voltage-enhanced tritium transport (ver-1n) and Joule-heating (ver-1o) verification cases #426