-
Notifications
You must be signed in to change notification settings - Fork 0
feat: 홈화면 UI 개편 #212
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
The head ref may contain hidden characters: "FLT-9-\uD648\uD654\uBA74-UI-\uAC1C\uD3B8"
Merged
feat: 홈화면 UI 개편 #212
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
091f181
feat: 추천 컬렉션 리스트 UI
kimjw2003 980ec3a
feat: OTT 바텀시트 UI 변경
kimjw2003 2d1a3d8
feat: 추천 컬렉션 무한스크롤
kimjw2003 cb0faa5
feat: RECENT -> FAMOUS 라우트 타입 변경 및 홈 인기 컬렉션 UI 개편
kimjw2003 be08a7c
feat: 홈 인기 컬렉션 API 연동 및 검색 공개 엔드포인트 토큰 제외
kimjw2003 d8b9653
Merge remote-tracking branch 'origin/develop' into FLT-9-홈화면-UI-개편
kimjw2003 ca4a6b6
feat: 홈화면 북마크 콘텐츠 API를 북마크 컬렉션 API로 교체
kimjw2003 5952267
fix: 홈화면 최근 저장한 콘텐츠 API를 신규 엔드포인트로 교체
kimjw2003 579bc19
feat: 컬렉션 목록 화면 하단 그라데이션 그림자 추가
kimjw2003 3a938c3
style: 컬렉션 목록 하단 그라데이션 높이 148dp로 조정
kimjw2003 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,11 +1,15 @@ | ||
| package com.flint.data.api | ||
|
|
||
| import com.flint.data.dto.base.BaseResponse | ||
| import com.flint.data.dto.home.response.PopularCollectionResponseDto | ||
| import com.flint.data.dto.home.response.RecommendCollectionResponseDto | ||
| import retrofit2.http.GET | ||
|
|
||
| interface HomeApi { | ||
|
|
||
| @GET("/api/v1/home/recommended-collections") | ||
| suspend fun getRecommendedCollections() : BaseResponse<RecommendCollectionResponseDto> | ||
| suspend fun getRecommendedCollections(): BaseResponse<RecommendCollectionResponseDto> | ||
|
|
||
| @GET("/api/v1/home/popular-collections") | ||
| suspend fun getPopularCollections(): BaseResponse<PopularCollectionResponseDto> | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
24 changes: 24 additions & 0 deletions
24
app/src/main/java/com/flint/data/dto/home/response/PopularCollectionResponseDto.kt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,24 @@ | ||
| package com.flint.data.dto.home.response | ||
|
|
||
| import kotlinx.serialization.SerialName | ||
| import kotlinx.serialization.Serializable | ||
|
|
||
| @Serializable | ||
| data class PopularCollectionResponseDto( | ||
| @SerialName("collections") | ||
| val collections: List<PopularCollectionItemResponseDto> | ||
| ) | ||
|
|
||
| @Serializable | ||
| data class PopularCollectionItemResponseDto( | ||
| @SerialName("id") | ||
| val id: String, | ||
| @SerialName("thumbnailUrl") | ||
| val thumbnailUrl: String?, | ||
| @SerialName("title") | ||
| val title: String, | ||
| @SerialName("nickname") | ||
| val nickname: String, | ||
| @SerialName("profileImageUrl") | ||
| val profileUrl: String? | ||
| ) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
DTO에 추가된 필드가 도메인 모델로 매핑되지 않음.
BookmarkedContentListResponseDto에totalCount,BookmarkedContentResponseDto에bookmarkCount와isBookmarked필드가 추가되었지만,ContentMapper.kt의toModel()확장 함수에서 이 필드들을 매핑하지 않고 있습니다 (app/src/main/java/com/flint/domain/mapper/content/ContentMapper.kt:13-28참조).API가 이제 이 데이터를 제공한다면 도메인 모델과 UI 상태에 반영되어야 합니다. 현재는 API 응답 데이터가 버려지고 있어 데이터 무결성 문제가 발생합니다.
🔧 제안: 매퍼 업데이트
ContentMapper.kt를 업데이트하여 새 필드를 매핑하세요:그리고
BookmarkedContentListModel및BookmarkedContentItemModel에도 해당 필드를 추가하세요.Also applies to: 24-27
🤖 Prompt for AI Agents