Conversation
Unframed IWAs remove the web app toolbar, but macOS still creates a
titled window in the remote Cocoa app shim. Its native close, minimize,
and zoom buttons remain visible over app content. Send the unframed
state to the actual NSWindow, hide or restore its standard buttons, and
remove the caption exclusion from browser layout.
Cover style-mask changes and permission grant/revoke transitions.
Document the reproduction, root cause, and validation for review.
Bug: 482535474
Test: Built Helium 153 chrome; compiled native and browser test objects;
manually verified IWA unframed/framed/unframed transitions.
Author
|
Apologies this shouldn't have been submitted yet. Please delete. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
In an unframed isolated web app on macOS, Helium removes the web-app toolbar but AppKit's close, minimize, and zoom buttons remain over the app's custom top border. Kitchen Sink IWA reproduces this after selecting Go unframed and granting window management permission. Chromium issue 482535474 confirms that an unframed window should not expose those controls; Chromium is not currently planning to support the feature on macOS.
Change
The browser sends titlebar-button visibility through the remote Cocoa window interface to the app-shim process, which owns the visible
NSWindow. The app shim hides or restores the three standard button views and reapplies that state after style-mask changes. Browser layout stops reserving caption-button space while the app is unframed. The window keeps its close and resize capabilities.The patch includes a native-window unit test and Mac assertions in the existing unframed-IWA browser test. The investigation report records reproduction steps, root cause, design, validation, and the Chromium submission path.
Validation and review status
chromeon macOS arm64 and manually verified Kitchen Sink IWA across unframed → framed → unframed permission transitions.main(Chromium 154) is pending; this PR is a draft until that patch stack and runtime are checked.This draft seeks maintainer confirmation that Helium wants to carry the macOS fix. The linked Chromium issue is an upstream bug report, but no Helium maintainer has approved this change yet.