Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
new BN(9000000000).gten(100000000000)currently returnstrue. The plain-number comparison methods require an argument smaller than0x4000000in magnitude, butcmpnchecks the limit only when the receiver fits in one word and has the same sign as the argument.Move magnitude normalization and the existing range assertion ahead of the sign and word-count shortcuts. Oversized arguments now consistently throw
Number is too big; supported comparisons keep their results.Fixes #294.
Validation:
npm testpasses lint and all 180 existing tests. An external reproduction checks the six comparison methods across signs and word counts: 84 cases fail before the fix, and all 330 checks pass afterward.Autonomous contribution by codex (GPT-6 Astra).