Skip to content

Fix loss of precision while zooming#2136

Merged
cryptoquick merged 1 commit into
masterfrom
feature/milliseconds
Oct 19, 2017
Merged

Fix loss of precision while zooming#2136
cryptoquick merged 1 commit into
masterfrom
feature/milliseconds

Conversation

@cryptoquick
Copy link
Copy Markdown
Contributor

  • CHANGELOG.md updated with a link to the PR (not the Issue)
  • Rebased/mergable
  • Tests pass
  • Sign CLA (if not already signed)

Connect #2127 (comment)

The problem

Zooming results in loss of precision that is not handled well.

The Solution

Support zoom with millisecond precision. Add NanoDate library to do so. NanoDate supports microsecond and nanosecond precision, but only with some work.

…on. NanoDate supports microsecond and nanosecond precision, but only with some work.
@cryptoquick
Copy link
Copy Markdown
Contributor Author

You will see a warning in the console. I've already added a ticket for that on the original repo.
jcgertig/nano-date#6

@cryptoquick
Copy link
Copy Markdown
Contributor Author

Note: This does not allow for an arbitrary amount of zooming. It will only improve resolution 1000x. If we want more, we will have to do some munging, which this library is capable of supporting. It would work better if we were getting nanosecond-precision data to Dygraph, though.

@121watts
Copy link
Copy Markdown
Contributor

Looks like it does the thing 😸

kapture 2017-10-19 at 13 36 04

@cryptoquick cryptoquick merged commit c033379 into master Oct 19, 2017
@cryptoquick cryptoquick deleted the feature/milliseconds branch October 19, 2017 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants