perf: defer asset picker search filtering - #254
Conversation
Improve asset picker search responsiveness. - Defer search filtering so input updates stay responsive - Memoize filtered asset results by assets, search keys, and deferred query - Keep default search keys referentially stable - Simplify search filtering to a single pass without Ramda helpers
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
WalkthroughAsset search now uses shared defaults, deferred queries, and memoized filtering. The filtering helper uses native case-insensitive matching with nullish-safe field handling. Asset list rendering is delegated to a memoized component. ChangesAsset search flow
Estimated code review effort: 2 (Simple) | ~10 minutes Merge Risk: ⚪ Minimal · up to This localized performance change is merge-ready after normal checks and review; no actionable merge-blocking risk remains. Suggested reviewers: Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
Deploying interwovenkit-testnet with
|
| Latest commit: |
023fd7c
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://c4226524.interwovenkit-testnet.pages.dev |
| Branch Preview URL: | https://perf-asset-picker-search.interwovenkit-testnet.pages.dev |
Deploying interwovenkit with
|
| Latest commit: |
023fd7c
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://123065af.interwovenkit.pages.dev |
| Branch Preview URL: | https://perf-asset-picker-search.interwovenkit.pages.dev |
Deploying interwovenkit-staging with
|
| Latest commit: |
023fd7c
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://40842e1f.interwovenkit-staging.pages.dev |
| Branch Preview URL: | https://perf-asset-picker-search.interwovenkit-staging.pages.dev |
simcheolhwan
left a comment
There was a problem hiding this comment.
The deferred value currently skips only the filtering calculation, while the slow result list still renders on the urgent input path. Requesting changes so the list rendering is deferred as intended.
Improve asset picker search responsiveness.
Summary by CodeRabbit