Fill substituted timetable cells to the row height - #47
Merged
Merged
Conversation
The amber wash lived on the inner box, which only sized to its content, so a dash next to a two-line subject left a white gap at the bottom. Paint the wash on the stretched cell instead, and cap home D-days at 2. Co-authored-by: Injoon Oh <injoon5@icloud.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
injoon5
marked this pull request as ready for review
August 21, 2026 07:04
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Substituted cells left a white strip at the bottom of the row whenever a neighbor was taller (subject + teacher vs a dash). The amber wash was on the inner box, which only sized to its content.
Paint the wash on the stretched cell instead, and make the inner hit area grow with the row.
Also sets
HOME_DDAY_LIMITto 2.Test plan