Repository navigation
Fix grid line color contrast against muted cells - #48
Merged
Merged
Conversation
--grid-line was mixed against --card, giving it almost no contrast against --muted in dark mode — the exact background used by the timetable's top header row and left period column, where the line appeared to vanish. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01J7ETLBhYrmFojZ1Mo4g3ns
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This branch had an error being deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adjusted the
--grid-lineCSS custom property to mix against--mutedinstead of--cardfor better visual contrast in data grid layouts.Changes
--grid-linecolor calculation to usevar(--muted)as the mix target instead ofvar(--card)bg-mutedand sit on the grid's outer edges, where a line tuned only for--cardcontrast becomes nearly invisibleDetails
The grid lines were previously tuned for contrast against the card background color, but header cells (which use the muted background) sit on the grid's top and left edges. This caused the grid lines to be nearly imperceptible in those critical areas. By mixing the grid line color against the muted background instead, the lines now maintain adequate contrast throughout the entire grid layout.
https://claude.ai/code/session_01J7ETLBhYrmFojZ1Mo4g3ns