Clean up tech stack descriptions and improve validation/UX - #114
Open
injoon5 wants to merge 1 commit into
Open
Conversation
Backend: - Enforce the 1-200 char comment limit (with trim) in the Convex applyEdit mutation — the public editComment action could bypass the SvelteKit/Zod layer entirely. Trim text in create for the same reason. - Reorder Zod .trim() before .min()/.max() so whitespace-only comments are rejected and trailing spaces don't push valid text over the limit. RSS feed: - Channel <link> pointed at the non-existent /rss.xml; use the site URL per the RSS 2.0 spec. - Add <guid> permalinks so readers can de-duplicate items. - Keep link labels (instead of deleting whole links), strip heading and emphasis markers in item descriptions — link-heavy posts previously produced empty bullet lists. UI papercuts: - Vote spinner showed on the wrong comment: the in-flight check ignored which comment the click animation belonged to. - /now page showed "Loading..." forever when the page had no content. - SeriesList rendered the current post as a clickable empty-href link that reloaded the page; now href-less with aria-current. - EN badge appeared for posts whose English version is unpublished. - LanguageSwitcher buttons now expose aria-pressed. - Remove duplicate <meta charset> from the home page head. - Distinct 404 copy for /projects listing vs a project page. Cleanup: - Drop the unused techstackDescriptions object (~4 KB of dead JSON serialized into the prerendered home page payload). - Correct stale CLAUDE.md claims (admin secret is never sent to the browser, detail pages are SSR not prerendered, schema table, removed legacy reply route, document IP_HASH_SECRET). https://claude.ai/code/session_01Gc2UdyWBUbdqkiR9uGnPaU
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes hardcoded tech stack descriptions from the home page loader, improves comment text validation and trimming, enhances RSS feed generation, fixes accessibility issues, and updates documentation to reflect recent schema and auth changes.
Key Changes
Home Page (
src/routes/+page.ts)techstackDescriptionsobject that was loaded but never usedposts,projects, andtechstackComment Validation (
src/lib/server/validation.ts&convex/comments.js).trim()before length validation in Zod schemas so whitespace-only comments are properly rejectedcreateandapplyEditmutations to enforce consistencyRSS Feed (
src/routes/internal/rss.xml/+server.ts)cleanText()to remove code blocks and inline code before other markdown cleanup<link>to point to website root (https://www.injoon5.com) per RSS 2.0 spec instead of feed URL<guid>element to each item for better feed reader compatibilityAccessibility & UX
votingAnim.idandvotingAnim.sideto prevent showing spinner on wrong commentSeriesList.svelteto useundefinedinstead of empty string for current post link (prevents reload) and addedaria-current="page"aria-pressedattribute to language switcher buttons/nowpage loading state messagingDocumentation (
CLAUDE.md)/api/comments/[id]/replyroute from docscommentUrlCounts,likeCounts,migrationMeta)IP_HASH_SECRETto environment variables sectionMinor Fixes
<meta charset="UTF-8" />from home page (SvelteKit handles this)resolvePublished()to only count published English versions toward EN badgehttps://claude.ai/code/session_01Gc2UdyWBUbdqkiR9uGnPaU