Keep navbar type readable on small screens - #174
Draft
injoon5 wants to merge 2 commits into
Draft
Conversation
Use text-2xl / text-base at all breakpoints so links and the wordmark stay readable on phones; wordmark still yields via min-w-0 + truncate. Remove obsolete mobile floating-dock body padding. Co-authored-by: Injoon Oh <injoon5@icloud.com>
Co-authored-by: Injoon Oh <injoon5@icloud.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
On viewports below
sm, navbar links dropped totext-sm(14px) and the wordmark totext-xl(20px) so four links would fit. That made the nav feel too small on phones.Fix
text-baseand wordmark attext-2xlat every widthmin-w-0) before the links wrap (shrink-0)Testing
Verified on
/blogat 375px and 320px:Navbar at 375px
Navbar at 320px
To show artifacts inline, enable in settings.