Publish models-router - #112
Merged
Merged
Conversation
The module was missing from the release allowlist, so every version until now built it and shipped it nowhere. The pretrained task classifier, its packaged index, ModelRouter.discoverLocal() and the catalog discovery added in 0.3.1 were all unreachable from a dependency — Maven Central has no models-router artifact at any version. Found by resolving the 0.3.1 artifacts after publishing rather than trusting the release to have covered everything it built. The catalog SPI was never affected: it lives in models-api, which is published, and its classes are present in the 0.3.1 jar. So the ModelJars provider work is unblocked either way. Adding a module to the allowlist pulls in two inventories that assert against it — RELEASING.md and the documentation module table — both of which are checked, and both updated here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
models-routerwas missing from the release allowlist inbuild.gradle.kts, so every versionuntil now built it and shipped it nowhere. Maven Central has no
models-routerartifact at anyversion.
That means the pretrained task classifier, its packaged 0.65 MB index,
ModelRouter.discoverLocal()and the catalog discovery added in 0.3.1 are all unreachable from a dependency.
Found by resolving the 0.3.1 artifacts after publishing rather than assuming the release covered
everything it built:
The catalog SPI itself was never affected — it lives in
models-api, which is published, and itsclasses are verifiably in the 0.3.1 jar. The ModelJars provider work is unblocked regardless.
Adding a module to the allowlist pulls in two inventories that assert against it,
RELEASING.mdand the documentation module table. Both updated.
Version moves to 0.3.2; 0.3.1 is immutable.