Skip to content

drop the PCI_ENABLE check #1043

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
opcm merged 1 commit into from
Jul 29, 2026
+0 −13
Merged

drop the PCI_ENABLE check #1043

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 0 additions & 13 deletions src/cpucounters.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7886,21 +7886,8 @@ void PCM::getPCICFGPMUsFromDiscovery(const unsigned int BoxType, const size_t s,
const auto n_regs = uncorePMUDiscovery->getBoxNumRegs(BoxType, s, die, pos);
auto makeRegister = [&pos, &numBoxes, &BoxType, &s](const uint64 rawAddr)
{
#ifndef PCI_ENABLE
constexpr auto PCI_ENABLE = 0x80000000ULL;
#endif
UncorePMUDiscovery::PCICFGAddress Addr;
Addr.raw = rawAddr;
if ((Addr.raw & PCI_ENABLE) == 0)
{
std::cerr << "PCM Error: PCI_ENABLE bit not set in address 0x" << std::hex << Addr.raw << std::dec << "\n";
std::cerr << "This is likely a bug in the uncore PMU discovery BIOS table. Contact your BIOS vendor.\n";
std::cerr << "Socket: " << s << "\n";
std::cerr << "Box type: " << BoxType << "\n";
std::cerr << "Box position: " << pos << "/" << numBoxes << "\n";
std::cerr << "Address: " << Addr.getStr() << "\n";
return std::shared_ptr<PCICFGRegister64>();
}
try {
auto handle = std::make_shared<PciHandleType>(0, (uint32)Addr.fields.bus,
(uint32)Addr.fields.device,
Expand Down
Loading