Repository navigation
Conversation
added 3 commits
November 11, 2026 15:35
samplise
requested review from
BalaBalaYi,
bikemechanic,
duck7216,
nash635 and
workingloong
as code owners
November 11, 2026 09:05
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1762 +/- ##
==========================================
+ Coverage 82.26% 82.29% +0.03%
==========================================
Files 255 255
Lines 25282 25432 +150
==========================================
+ Hits 20797 20929 +132
- Misses 4485 4503 +18 ☔ View full report in Codecov by Harness. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Added an experimental four-GPU MoE in-place recovery example under examples/in_place_restart/:
Why are the changes needed?
Current recovery normally restarts all ranks and repeats model, optimizer, and distributed-runtime initialization. This example validates a lower-overhead approach where only the failed rank gets a new process, while healthy ranks keep their PIDs, CUDA contexts, model parameters, and optimizer objects and rejoin a reconfigured process group.
Does this PR introduce any user-facing change?
Yes, but only as a new opt-in example. It introduces no changes to existing training behavior. The example requires PyTorch 2.14+, the experimental nccl2 backend, and NCCL 2.28+.
How was this patch tested?
Passed Python compilation, style, shell syntax, and recovery-protocol smoke checks.
Passed Docker BuildKit static validation.
Validated with a four-GPU run:- Rank 2 failed at step 23.