Skip to content

Fix translation loading state and prevent infinite spinner #1516

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sai-kamal0905 wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix translation loading state and prevent infinite spinner #1516

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2b88ac1
Fix translation active state and promise handling
sai-kamal0905 Feb 24, 2026
06748ff
Improve translation state handling and cleanup
sai-kamal0905 Feb 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 21 additions & 8 deletions src/plugins/translate/TranslationManager.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,12 +101,16 @@ export class TranslationManager {
*/

getTranslation = async (fromLang, toLang, pageIndex, paragraphIndex, text, priority) => {
this.active = true;
if (fromLang == toLang || !fromLang || !toLang) {
return;
}
if (!this.translator) { //Ensure translator is initialized before use
await this.initWorker();
}
if (fromLang == toLang || !fromLang || !toLang) {
return "";
}
this.active = true; //Moved active = true after validation to avoid setting active when no translation is performed (prevents infinite loading state).

const key = `${fromLang}${toLang}-${pageIndex}:${paragraphIndex}`;
const cachedEntry = this.alreadyTranslated.entries.find(x => x.index == key);
const cachedEntry = this.alreadyTranslated.entries.find(x => x.index == key); //If Cache supports .get() method, better use that.

if (cachedEntry) {
return cachedEntry.response;
Expand All @@ -129,10 +133,11 @@ export class TranslationManager {
reject: _reject,
};

if (!text) {
if (!text) { //Handle empty text safely
this.currentlyTranslating[key].reject("No text was provided");
delete this.currentlyTranslating[key];
return promise;
}
}
this.translator.translate({
to: toLang,
from: fromLang,
Expand All @@ -143,7 +148,15 @@ export class TranslationManager {
const response = resp;
this.currentlyTranslating[key].resolve(response.target.text);
this.alreadyTranslated.add({index: key, response: response.target.text});
delete this.currentlyTranslating[key];
}).catch((error) => {
console.error("Translation failed:", error);
this.currentlyTranslating[key].reject(error);
})
.finally(() => { //Proper cleanup after translation completes
delete this.currentlyTranslating[key];
if (Object.keys(this.currentlyTranslating).length === 0) {
this.active = false;
}
});

return promise;
Expand Down