Skip to content

Switch "Copy Link to Highlight" to use custom highlight rendering + beginnings of annotations support #1538

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
schu96 wants to merge 6 commits into
base: master
Choose a base branch
from

Copy link to highlight param handling revision

0940d6e
Select commit
Loading
Failed to load commit list.
Open

Switch "Copy Link to Highlight" to use custom highlight rendering + beginnings of annotations support #1538

Copy link to highlight param handling revision
0940d6e
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project failed May 14, 2026 in 0s

65.07% (-3.92%) compared to 2908b1e

View this Pull Request on Codecov

65.07% (-3.92%) compared to 2908b1e

Details

Codecov Report

❌ Patch coverage is 4.73186% with 302 lines in your changes missing coverage. Please review.
✅ Project coverage is 65.07%. Comparing base (2908b1e) to head (0940d6e).
⚠️ Report is 4 commits behind head on master.

Files with missing lines Patch % Lines
src/util/TextSelectionManager.js 2.90% 259 Missing and 8 partials ⚠️
src/plugins/url/UrlPlugin.js 0.00% 23 Missing ⚠️
src/plugins/url/plugin.url.js 50.00% 6 Missing ⚠️
src/BookReader.js 25.00% 3 Missing ⚠️
src/plugins/plugin.text_selection.js 0.00% 3 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #1538      +/-   ##
==========================================
- Coverage   68.98%   65.07%   -3.92%     
==========================================
  Files          65       65              
  Lines        5556     5815     +259     
  Branches     1229     1291      +62     
==========================================
- Hits         3833     3784      -49     
- Misses       1689     1989     +300     
- Partials       34       42       +8

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
View more details on Codecov