Skip to content

Fix Navbar responsive controls for shadow DOM hosts #1539

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jbuckner wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix Navbar responsive controls for shadow DOM hosts #1539

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 19 additions & 12 deletions src/BookReader/Navbar/Navbar.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -217,33 +217,40 @@ export class Navbar {
* NOTE: `this.minimumControls`, `this.maximumControls`, and .BRnavMobile switch on resize
*/
showMobileControls() {
// Scope queries to the navbar's own jQuery-wrapped root instead of
// `document`. `document.querySelector` can't cross shadow DOM
// boundaries, so when BookReader is hosted inside a shadow tree
// (e.g. offshoot's details-page), every lookup here returns null
// and no `.hide` toggling happens — leaving both the mobile-only
// viewmode button and the three desktop view-mode buttons visible
// at the same time.
//
// `this.$nav` is built from a fragment with two top-level sibling
// divs (.BRnavMobile + .BRnavMain), so `.filter()` (not `.find()`)
// is required for the outer classes.
const $main = this.$nav?.filter('.BRnavMain');
this.minimumControls.forEach((control) => {
const element = document.querySelector(`.BRnavMain .controls .${control}`);
if (element) element.classList.remove('hide');
$main?.find(`.controls .${control}`).removeClass('hide');
});
this.maximumControls.forEach((control) => {
const element = document.querySelector(`.BRnavMain .controls .${control}`);
if (element) element.classList.add('hide');
$main?.find(`.controls .${control}`).addClass('hide');
});
const mobileNav = document.querySelector(`.BRnavMobile`);
if (mobileNav) mobileNav.classList.remove('hide');
this.$nav?.filter('.BRnavMobile').removeClass('hide');
}

/**
* Switch Book controls to desktop mode
* NOTE: `this.minimumControls`, `this.maximumControls`, and .BRnavMobile switch on resize
*/
showDesktopControls() {
const $main = this.$nav?.filter('.BRnavMain');
this.maximumControls.forEach((control) => {
const element = document.querySelector(`.BRnavMain .controls .${control}`);
if (element) element.classList.remove('hide');
$main?.find(`.controls .${control}`).removeClass('hide');
});
this.minimumControls.forEach((control) => {
const element = document.querySelector(`.BRnavMain .controls .${control}`);
if (element) element.classList.add('hide');
$main?.find(`.controls .${control}`).addClass('hide');
});
const mobileNav = document.querySelector(`.BRnavMobile`);
if (mobileNav) mobileNav.classList.add('hide');
this.$nav?.filter('.BRnavMobile').addClass('hide');
}

/**
Expand Down
Loading