fix(windows): use WinTab for pen contact while preserving mouse-mapped stylus buttons#127
Open
DustyShoe wants to merge 3 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR improves Windows tablet behavior in the launcher for devices where the stylus side buttons are mapped by the driver to standard mouse buttons.
The key change is to stop relying on Chromium/Electron to interpret the entire tablet input stream on its own. Instead:
This matches the intended behavior on the affected hardware: pen is only needed for contact + pressure, while buttons should behave exactly like mouse input.
Problem
On the affected Windows tablet setup, Chromium/Electron does not handle the split between tablet input and compatibility mouse input reliably under Windows Ink.
In practice this caused issues such as:
MMBgetting stuck on releaseRMBbehaving inconsistentlyThe root issue is not canvas logic itself, but limited tablet-input handling in Chromium/Electron for this kind of mixed input path.
Approach
This PR adds a Windows-only native WinTab bridge and uses it only for the primary pen contact path:
wintab-pen-bridgemoduleScope
This PR is intentionally limited to the Windows tablet-input fix in the launcher.
It does not include unrelated release/process/infrastructure changes.
Notes