fix(cli): mark Cordova CocoaPods plugins as incompatible in SPM#8463
Open
jcesarmobile wants to merge 1 commit intomainfrom
Open
fix(cli): mark Cordova CocoaPods plugins as incompatible in SPM#8463jcesarmobile wants to merge 1 commit intomainfrom
jcesarmobile wants to merge 1 commit intomainfrom
Conversation
jcesarmobile
requested review from
ItsChaceD,
OS-pedrogustavobilro,
OS-ruimoreiramendes,
alexgerardojacinto,
andredestro,
eric-horodyski,
markemer and
theproducer
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If the plugin has a podspec entry and doesn't have a package=SPM on the ios platform entry in plugin.xml, mark it as incompatible as it won't work.
This is a bit hacky, the proper place to do it would be in
resolvePluginas that's where we mark plugins as incompatible, but we don't have theconfigobject available to check if it's SPM, so doing it inside update.