Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
OS-jacobbell
approved these changes
May 15, 2026
Contributor
OS-jacobbell
left a comment
OS-jacobbell
left a comment
There was a problem hiding this comment.
Makes sense, good find!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue number: resolves #24995
What is the current behavior?
In
createIonRouter, the replace-action branch resolvesrouteInfo.routerDirectionandrouteInfo.routerAnimationby preferring the leaving route's values over the ones the caller passed in. The leaving route wins whenever it has any value set, souseIonRouter.navigate(url, 'forward', 'replace')called after a back navigation ends up withrouterDirection: 'back', and the same call from the initial route ends up with'none'. The caller's explicit direction is silently discarded.What is the new behavior?
The precedence is flipped: the caller's
routerDirectionandrouterAnimationare kept, and the leaving route's values are only used as a fallback when nothing was provided.forward + replacenow animates forward regardless of how the user got to the leaving page, and the defaultuseIonRouter.replace(url)keeps the'root'direction it was constructed with instead of inheriting whatever the leaving route had recorded.Does this introduce a breaking change?
Other information