Repository navigation
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue number: resolves internal
What is the current behavior?
ion-dividerdoes not fragment styles based on themes.What is the new behavior?
ion-dividerto a singledivider.scssdriven by tokensIonDividerRecipeandIonDividerConfigwith ionic, ios and md token valuesspacingnow comes from theIonDivider.spacingconfig instead of a hardcoded"medium"colorandthickness, sincewidthwould read as the divider's lengthinsetproperty, since the design has no inset divider;class="ion-padding-horizontal"gives the same resultnonespacing, which is always 0 and has no token, matching the design.xxsmallchanges from 0 to 4pxDoes this introduce a breaking change?
Other information
ion-dividerhas only shipped onnext, so the removedinsetproperty and the replaced--margin-top,--margin-bottom,--padding-startand--padding-endvariables need noBREAKING.mdentry.Hairline rendering on iOS is tracked as a follow-up PR on top of this one.
How to test
insetproperty.none) to 40px (xxlarge).xxsmallis new at 4px; every other size matches the "No Inset" column before.