Repository navigation
Conversation
Recipe values under mediaQuery.min.resolution set the same variable inside a media query. A value a custom theme sets replaces the base theme's media query values for that key, so it applies on every screen.
The line is a filled box instead of a border, since WebKit skips borders thinner than one CSS pixel at some positions. The ios theme sets the thickness per screen density.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue number: resolves #30772
What is the current behavior?
On iOS, WebKit skips borders thinner than one CSS pixel at some positions on the page, so the 0.55px line between items disappears while scrolling.
What is the new behavior?
mediaQueryrecipe key: values undermediaQuery.min.resolutionset the same variable inside a media query. A value a custom theme sets replaces the base theme's media query values for that key, so it applies on every screen.ion-dividerdraws its line as a filled box instead of a border, and the ios theme sets it to one screen pixel at each density.ion-itemdraws its lines withion-divider.Does this introduce a breaking change?
On ios,
--border-widthand--inner-border-widthno longer draw the lines between items. Apps that set them to hide or resize a line uselines="none"to hide it, or style it withion-item::part(line)(full width) orion-item::part(inner-line)(inset).--border-colorstill sets the line color.Other information
The hairlines test page reproduces the bug in Safari on an iPhone or the iOS simulator. Tap the Shift button to move the lines to new positions.