Skip to content

fix(explorer): default assets section to 10 items per page #299

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Juligs wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

fix(explorer): default assets section to 10 items per page #299

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
222f45f
fix(explorer): default assets section to 10 items per page
Juligs Aug 4, 2026
58b33ad
Merge branch 'develop' into feat/fix-assets-section-show-default
evavirseda Aug 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 19 additions & 3 deletions apps/explorer/src/components/owned-objects/OwnedObjects.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,7 @@ interface OwnedObjectsProps {
}

export function OwnedObjects({ id }: OwnedObjectsProps): JSX.Element {
const [limit, setLimit] = useState(50);
const [limit, setLimit] = useState(10);
const [filter, setFilter] = useLocalStorage<string | undefined>(
'owned-objects-category-filter',
undefined,
Expand All @@ -98,9 +98,19 @@ export function OwnedObjects({ id }: OwnedObjectsProps): JSX.Element {
ObjectViewMode.Thumbnail,
);

const [prevId, setPrevId] = useState(id);
const idChanged = id !== prevId;

useEffect(() => {
if (idChanged) {
setPrevId(id);
setFilter(undefined);
}
}, [idChanged, id, setFilter]);

const ownedObjects = useGetCategorizedOwnedObjects(id, limit);

const activeCategory = (filter as OwnedObjectCategory) ?? undefined;
const activeCategory = (idChanged ? undefined : (filter as OwnedObjectCategory)) ?? undefined;

const activeCategoryData = (() => {
switch (activeCategory) {
Expand All @@ -119,6 +129,12 @@ export function OwnedObjects({ id }: OwnedObjectsProps): JSX.Element {

const { availableCategories, isPending: isLoading } = ownedObjects;

const totalAssetsCount =
ownedObjects.nft.totalItems +
ownedObjects.name.totalItems +
ownedObjects.kiosk.totalItems +
ownedObjects.other.totalItems;

useEffect(() => {
if (!isLoading && availableCategories.length) {
if (!filter || !availableCategories.includes(filter as OwnedObjectCategory)) {
Expand Down Expand Up @@ -223,7 +239,7 @@ export function OwnedObjects({ id }: OwnedObjectsProps): JSX.Element {
<Tooltip text="Total assets owned">
<Badge
type={BadgeType.Neutral}
label={String(sortedDataByDisplayImages.length)}
label={String(totalAssetsCount)}
/>
</Tooltip>
</span>
Expand Down
Loading