Skip to content

Fix BCAL normalization of first block #286

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
bhawkins wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

Fix BCAL normalization of first block #286

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1cb214f
handle cases where first pulse isn't BCAL
bhawkins Jun 4, 2026
c10b384
Handle initial BCAL case before over-writing it.
bhawkins Jun 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions python/packages/nisar/antenna/beamformer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -815,6 +815,11 @@ def compute_transmit_pattern_weights(tx_trm_info, norm=False):
if np.isclose(abs(tx_weights[bcal_lines_idx]).min(), 0):
raise RuntimeError('Zero-value BCAL data is encountered!')

# handle case where first line isn't BCAL
bcal_rel = (tx_weights[bcal_lines_idx[0]] /
tx_weights[bcal_lines_idx[0], 0])
tx_weights[:bcal_lines_idx[0]] /= bcal_rel

for line_start, line_stop in zip(bcal_lines_idx[:-1],
bcal_lines_idx[1:]):
# normalize BCAL wrt to the first TX channel to get relative
Expand Down
Loading