Skip to content

Security: Integer Overflow in Chirp Size Calculation #321

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
tomaioo wants to merge 1 commit into from
+1 −2
Closed

Security: Integer Overflow in Chirp Size Calculation #321

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions cxx/isce3/focus/Chirp.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,8 +28,7 @@ formLinearChirp(double chirprate,

// check for possible overflow before double -> int conversion
double d_size = samplerate * duration + 1;
double d_maxsize = std::numeric_limits<int>::max();
if (d_size > d_maxsize) {
if (d_size > std::numeric_limits<int>::max() || d_size < std::numeric_limits<int>::min()) {
throw isce3::except::OverflowError(ISCE_SRCINFO(), "chirp size exceeds max int value");
}

Expand Down