Skip to content

Fail fast when compilation fails in the macOS launch script #197

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
domenix wants to merge 2 commits into from
Closed

Fail fast when compilation fails in the macOS launch script #197

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
23d9f92
Make scc exit with a non-zero code when compilation fails
domenix Jul 25, 2026
cf23341
Abort modded launch on macOS when script compilation fails
domenix Jul 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions assets/macos/archive/launch_modded.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,14 @@
#!/usr/bin/env bash
# Compiles REDscript and launches the game.
set -euo pipefail

game_dir=$(dirname "$(readlink -f "$0")")

"$game_dir/engine/tools/scc" -compile "$game_dir/r6/scripts"
"$game_dir/Cyberpunk2077.app/Contents/MacOS/Cyberpunk2077"
if ! "$game_dir/engine/tools/scc" -compile "$game_dir/r6/scripts"; then
message="REDscript compilation failed, the game was not launched. Check r6/logs/redscript_rCURRENT.log for details."
echo "$message" >&2
osascript -e "display alert \"REDscript\" message \"$message\" as critical" >/dev/null 2>&1 || true
exit 1
fi

open "$game_dir/Cyberpunk2077.app"
6 changes: 6 additions & 0 deletions crates/scc/cli/src/main.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,7 @@ fn run(r6_dir: &Path, args: Option<Arguments>) -> anyhow::Result<()> {
.context("missing 'settings_add_script_path'")?;
let compile = api.compile.context("missing 'compile'")?;
let free_result = api.free_result.context("missing 'free_result'")?;
let get_success = api.get_success.context("missing 'get_success'")?;

let root = c_path(r6_dir)?;

Expand All @@ -72,7 +73,12 @@ fn run(r6_dir: &Path, args: Option<Arguments>) -> anyhow::Result<()> {
}

let res = compile(settings);
let succeeded = !get_success(res).is_null();
free_result(res);

if !succeeded {
std::process::exit(1);
}
}

Ok(())
Expand Down
Loading