Skip to content

stop sending messages on closed websockets - #881

Merged
rolyatmax merged 1 commit into
mainfrom
taylor/stop-sending-msgs-on-closed-websockets
Jan 13, 2026
Merged

stop sending messages on closed websockets#881
rolyatmax merged 1 commit into
mainfrom
taylor/stop-sending-msgs-on-closed-websockets

stop sending messages on closed websockets

130bd0c
Select commit
Loading
Failed to load commit list.
Sign in for the full log view
GitHub Actions / clippy succeeded Jan 13, 2026 in 1s

clippy

51 warnings

Details

Results

Message level Amount
Internal compiler error 0
Error 0
Warning 51
Note 0
Help 0

Versions

  • rustc 1.92.0 (ded5c06cf 2025-12-08)
  • cargo 1.92.0 (344c4567c 2025-10-21)
  • clippy 0.1.92 (ded5c06cf2 2025-12-08)

Annotations

Check warning on line 32 in plane/src/proxy/cert_pair.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

hiding a lifetime that's elided elsewhere is confusing 

warning: hiding a lifetime that's elided elsewhere is confusing
  --> plane/src/proxy/cert_pair.rs:32:22
   |
32 | fn load_key_der(pem: &str) -> Result<PrivateKeyDer> {
   |                      ^^^^            ^^^^^^^^^^^^^ the same lifetime is hidden here
   |                      |
   |                      the lifetime is elided here
   |
   = help: the same lifetime is referred to in inconsistent ways, making the signature confusing
help: use `'_` for type paths
   |
32 | fn load_key_der(pem: &str) -> Result<PrivateKeyDer<'_>> {
   |                                                   ++++

Check warning on line 22 in plane/src/proxy/cert_pair.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

hiding a lifetime that's elided elsewhere is confusing 

warning: hiding a lifetime that's elided elsewhere is confusing
  --> plane/src/proxy/cert_pair.rs:22:24
   |
22 | fn load_cert_ders(pem: &str) -> Result<Vec<CertificateDer>> {
   |                        ^^^^                ^^^^^^^^^^^^^^ the same lifetime is hidden here
   |                        |
   |                        the lifetime is elided here
   |
   = help: the same lifetime is referred to in inconsistent ways, making the signature confusing
help: use `'_` for type paths
   |
22 | fn load_cert_ders(pem: &str) -> Result<Vec<CertificateDer<'_>>> {
   |                                                          ++++

Check warning on line 87 in plane/src/database/mod.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

hiding a lifetime that's elided elsewhere is confusing 

warning: hiding a lifetime that's elided elsewhere is confusing
  --> plane/src/database/mod.rs:87:23
   |
87 |     pub fn controller(&self) -> controller::ControllerDatabase {
   |                       ^^^^^     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ the same lifetime is hidden here
   |                       |
   |                       the lifetime is elided here
   |
   = help: the same lifetime is referred to in inconsistent ways, making the signature confusing
help: use `'_` for type paths
   |
87 |     pub fn controller(&self) -> controller::ControllerDatabase<'_> {
   |                                                               ++++

Check warning on line 83 in plane/src/database/mod.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

hiding a lifetime that's elided elsewhere is confusing 

warning: hiding a lifetime that's elided elsewhere is confusing
  --> plane/src/database/mod.rs:83:17
   |
83 |     pub fn keys(&self) -> backend_key::KeysDatabase {
   |                 ^^^^^     ^^^^^^^^^^^^^^^^^^^^^^^^^ the same lifetime is hidden here
   |                 |
   |                 the lifetime is elided here
   |
   = help: the same lifetime is referred to in inconsistent ways, making the signature confusing
help: use `'_` for type paths
   |
83 |     pub fn keys(&self) -> backend_key::KeysDatabase<'_> {
   |                                                    ++++

Check warning on line 75 in plane/src/database/mod.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

hiding a lifetime that's elided elsewhere is confusing 

warning: hiding a lifetime that's elided elsewhere is confusing
  --> plane/src/database/mod.rs:75:20
   |
75 |     pub fn backend(&self) -> BackendDatabase {
   |                    ^^^^^     ^^^^^^^^^^^^^^^ the same lifetime is hidden here
   |                    |
   |                    the lifetime is elided here
   |
   = help: the same lifetime is referred to in inconsistent ways, making the signature confusing
help: use `'_` for type paths
   |
75 |     pub fn backend(&self) -> BackendDatabase<'_> {
   |                                             ++++

Check warning on line 71 in plane/src/database/mod.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

hiding a lifetime that's elided elsewhere is confusing 

warning: hiding a lifetime that's elided elsewhere is confusing
  --> plane/src/database/mod.rs:71:17
   |
71 |     pub fn node(&self) -> NodeDatabase {
   |                 ^^^^^     ^^^^^^^^^^^^ the same lifetime is hidden here
   |                 |
   |                 the lifetime is elided here
   |
   = help: the same lifetime is referred to in inconsistent ways, making the signature confusing
help: use `'_` for type paths
   |
71 |     pub fn node(&self) -> NodeDatabase<'_> {
   |                                       ++++

Check warning on line 67 in plane/src/database/mod.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

hiding a lifetime that's elided elsewhere is confusing 

warning: hiding a lifetime that's elided elsewhere is confusing
  --> plane/src/database/mod.rs:67:20
   |
67 |     pub fn cluster(&self) -> ClusterDatabase {
   |                    ^^^^^     ^^^^^^^^^^^^^^^ the same lifetime is hidden here
   |                    |
   |                    the lifetime is elided here
   |
   = help: the same lifetime is referred to in inconsistent ways, making the signature confusing
help: use `'_` for type paths
   |
67 |     pub fn cluster(&self) -> ClusterDatabase<'_> {
   |                                             ++++

Check warning on line 63 in plane/src/database/mod.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

hiding a lifetime that's elided elsewhere is confusing 

warning: hiding a lifetime that's elided elsewhere is confusing
  --> plane/src/database/mod.rs:63:18
   |
63 |     pub fn drone(&self) -> DroneDatabase {
   |                  ^^^^^     ^^^^^^^^^^^^^ the same lifetime is hidden here
   |                  |
   |                  the lifetime is elided here
   |
   = help: the same lifetime is referred to in inconsistent ways, making the signature confusing
help: use `'_` for type paths
   |
63 |     pub fn drone(&self) -> DroneDatabase<'_> {
   |                                         ++++

Check warning on line 59 in plane/src/database/mod.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

hiding a lifetime that's elided elsewhere is confusing 

warning: hiding a lifetime that's elided elsewhere is confusing
  --> plane/src/database/mod.rs:59:17
   |
59 |     pub fn acme(&self) -> acme::AcmeDatabase {
   |                 ^^^^^     ^^^^^^^^^^^^^^^^^^ the same lifetime is hidden here
   |                 |
   |                 the lifetime is elided here
   |
   = help: the same lifetime is referred to in inconsistent ways, making the signature confusing
   = note: `#[warn(mismatched_lifetime_syntaxes)]` on by default
help: use `'_` for type paths
   |
59 |     pub fn acme(&self) -> acme::AcmeDatabase<'_> {
   |                                             ++++

Check warning on line 32 in plane/src/proxy/cert_pair.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

hiding a lifetime that's elided elsewhere is confusing 

warning: hiding a lifetime that's elided elsewhere is confusing
  --> plane/src/proxy/cert_pair.rs:32:22
   |
32 | fn load_key_der(pem: &str) -> Result<PrivateKeyDer> {
   |                      ^^^^            ^^^^^^^^^^^^^ the same lifetime is hidden here
   |                      |
   |                      the lifetime is elided here
   |
   = help: the same lifetime is referred to in inconsistent ways, making the signature confusing
help: use `'_` for type paths
   |
32 | fn load_key_der(pem: &str) -> Result<PrivateKeyDer<'_>> {
   |                                                   ++++

Check warning on line 22 in plane/src/proxy/cert_pair.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

hiding a lifetime that's elided elsewhere is confusing 

warning: hiding a lifetime that's elided elsewhere is confusing
  --> plane/src/proxy/cert_pair.rs:22:24
   |
22 | fn load_cert_ders(pem: &str) -> Result<Vec<CertificateDer>> {
   |                        ^^^^                ^^^^^^^^^^^^^^ the same lifetime is hidden here
   |                        |
   |                        the lifetime is elided here
   |
   = help: the same lifetime is referred to in inconsistent ways, making the signature confusing
help: use `'_` for type paths
   |
22 | fn load_cert_ders(pem: &str) -> Result<Vec<CertificateDer<'_>>> {
   |                                                          ++++

Check warning on line 87 in plane/src/database/mod.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

hiding a lifetime that's elided elsewhere is confusing 

warning: hiding a lifetime that's elided elsewhere is confusing
  --> plane/src/database/mod.rs:87:23
   |
87 |     pub fn controller(&self) -> controller::ControllerDatabase {
   |                       ^^^^^     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ the same lifetime is hidden here
   |                       |
   |                       the lifetime is elided here
   |
   = help: the same lifetime is referred to in inconsistent ways, making the signature confusing
help: use `'_` for type paths
   |
87 |     pub fn controller(&self) -> controller::ControllerDatabase<'_> {
   |                                                               ++++

Check warning on line 83 in plane/src/database/mod.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

hiding a lifetime that's elided elsewhere is confusing 

warning: hiding a lifetime that's elided elsewhere is confusing
  --> plane/src/database/mod.rs:83:17
   |
83 |     pub fn keys(&self) -> backend_key::KeysDatabase {
   |                 ^^^^^     ^^^^^^^^^^^^^^^^^^^^^^^^^ the same lifetime is hidden here
   |                 |
   |                 the lifetime is elided here
   |
   = help: the same lifetime is referred to in inconsistent ways, making the signature confusing
help: use `'_` for type paths
   |
83 |     pub fn keys(&self) -> backend_key::KeysDatabase<'_> {
   |                                                    ++++

Check warning on line 75 in plane/src/database/mod.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

hiding a lifetime that's elided elsewhere is confusing 

warning: hiding a lifetime that's elided elsewhere is confusing
  --> plane/src/database/mod.rs:75:20
   |
75 |     pub fn backend(&self) -> BackendDatabase {
   |                    ^^^^^     ^^^^^^^^^^^^^^^ the same lifetime is hidden here
   |                    |
   |                    the lifetime is elided here
   |
   = help: the same lifetime is referred to in inconsistent ways, making the signature confusing
help: use `'_` for type paths
   |
75 |     pub fn backend(&self) -> BackendDatabase<'_> {
   |                                             ++++

Check warning on line 71 in plane/src/database/mod.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

hiding a lifetime that's elided elsewhere is confusing 

warning: hiding a lifetime that's elided elsewhere is confusing
  --> plane/src/database/mod.rs:71:17
   |
71 |     pub fn node(&self) -> NodeDatabase {
   |                 ^^^^^     ^^^^^^^^^^^^ the same lifetime is hidden here
   |                 |
   |                 the lifetime is elided here
   |
   = help: the same lifetime is referred to in inconsistent ways, making the signature confusing
help: use `'_` for type paths
   |
71 |     pub fn node(&self) -> NodeDatabase<'_> {
   |                                       ++++

Check warning on line 67 in plane/src/database/mod.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

hiding a lifetime that's elided elsewhere is confusing 

warning: hiding a lifetime that's elided elsewhere is confusing
  --> plane/src/database/mod.rs:67:20
   |
67 |     pub fn cluster(&self) -> ClusterDatabase {
   |                    ^^^^^     ^^^^^^^^^^^^^^^ the same lifetime is hidden here
   |                    |
   |                    the lifetime is elided here
   |
   = help: the same lifetime is referred to in inconsistent ways, making the signature confusing
help: use `'_` for type paths
   |
67 |     pub fn cluster(&self) -> ClusterDatabase<'_> {
   |                                             ++++

Check warning on line 63 in plane/src/database/mod.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

hiding a lifetime that's elided elsewhere is confusing 

warning: hiding a lifetime that's elided elsewhere is confusing
  --> plane/src/database/mod.rs:63:18
   |
63 |     pub fn drone(&self) -> DroneDatabase {
   |                  ^^^^^     ^^^^^^^^^^^^^ the same lifetime is hidden here
   |                  |
   |                  the lifetime is elided here
   |
   = help: the same lifetime is referred to in inconsistent ways, making the signature confusing
help: use `'_` for type paths
   |
63 |     pub fn drone(&self) -> DroneDatabase<'_> {
   |                                         ++++

Check warning on line 59 in plane/src/database/mod.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

hiding a lifetime that's elided elsewhere is confusing 

warning: hiding a lifetime that's elided elsewhere is confusing
  --> plane/src/database/mod.rs:59:17
   |
59 |     pub fn acme(&self) -> acme::AcmeDatabase {
   |                 ^^^^^     ^^^^^^^^^^^^^^^^^^ the same lifetime is hidden here
   |                 |
   |                 the lifetime is elided here
   |
   = help: the same lifetime is referred to in inconsistent ways, making the signature confusing
   = note: `#[warn(mismatched_lifetime_syntaxes)]` on by default
help: use `'_` for type paths
   |
59 |     pub fn acme(&self) -> acme::AcmeDatabase<'_> {
   |                                             ++++

Check warning on line 107 in plane/src/database/drone.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

manual implementation of `.is_multiple_of()` 

warning: manual implementation of `.is_multiple_of()`
   --> plane/src/database/drone.rs:107:31
    |
107 |         let seen_in_last = if seen_in_last.subsec_nanos() % 1000 == 0 {
    |                               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace with: `seen_in_last.subsec_nanos().is_multiple_of(1000)`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.92.0/index.html#manual_is_multiple_of
    = note: `#[warn(clippy::manual_is_multiple_of)]` on by default

Check warning on line 107 in plane/src/database/drone.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

manual implementation of `.is_multiple_of()` 

warning: manual implementation of `.is_multiple_of()`
   --> plane/src/database/drone.rs:107:31
    |
107 |         let seen_in_last = if seen_in_last.subsec_nanos() % 1000 == 0 {
    |                               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace with: `seen_in_last.subsec_nanos().is_multiple_of(1000)`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.92.0/index.html#manual_is_multiple_of
    = note: `#[warn(clippy::manual_is_multiple_of)]` on by default

Check warning on line 61 in plane/src/controller/error.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

the `Err`-variant returned from this function is very large 

warning: the `Err`-variant returned from this function is very large
  --> plane/src/controller/error.rs:61:10
   |
61 |     ) -> Result<T, Response>;
   |          ^^^^^^^^^^^^^^^^^^^ the `Err`-variant is at least 128 bytes
   |
   = help: try reducing the size of `hyper::Response<axum::body::Body>`, for example by boxing large elements or replacing it with `Box<hyper::Response<axum::body::Body>>`
   = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.92.0/index.html#result_large_err

Check warning on line 48 in plane/src/controller/error.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

the `Err`-variant returned from this function is very large 

warning: the `Err`-variant returned from this function is very large
  --> plane/src/controller/error.rs:48:55
   |
48 |     fn or_internal_error(self, user_message: &str) -> Result<T, Response> {
   |                                                       ^^^^^^^^^^^^^^^^^^^ the `Err`-variant is at least 128 bytes
   |
   = help: try reducing the size of `hyper::Response<axum::body::Body>`, for example by boxing large elements or replacing it with `Box<hyper::Response<axum::body::Body>>`
   = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.92.0/index.html#result_large_err

Check warning on line 44 in plane/src/controller/error.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

the `Err`-variant returned from this function is very large 

warning: the `Err`-variant returned from this function is very large
  --> plane/src/controller/error.rs:44:50
   |
44 |     fn or_not_found(self, user_message: &str) -> Result<T, Response> {
   |                                                  ^^^^^^^^^^^^^^^^^^^ the `Err`-variant is at least 128 bytes
   |
   = help: try reducing the size of `hyper::Response<axum::body::Body>`, for example by boxing large elements or replacing it with `Box<hyper::Response<axum::body::Body>>`
   = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.92.0/index.html#result_large_err
   = note: `#[warn(clippy::result_large_err)]` on by default

Check warning on line 61 in plane/src/controller/error.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

the `Err`-variant returned from this function is very large 

warning: the `Err`-variant returned from this function is very large
  --> plane/src/controller/error.rs:61:10
   |
61 |     ) -> Result<T, Response>;
   |          ^^^^^^^^^^^^^^^^^^^ the `Err`-variant is at least 128 bytes
   |
   = help: try reducing the size of `hyper::Response<axum::body::Body>`, for example by boxing large elements or replacing it with `Box<hyper::Response<axum::body::Body>>`
   = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.92.0/index.html#result_large_err

Check warning on line 48 in plane/src/controller/error.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

the `Err`-variant returned from this function is very large 

warning: the `Err`-variant returned from this function is very large
  --> plane/src/controller/error.rs:48:55
   |
48 |     fn or_internal_error(self, user_message: &str) -> Result<T, Response> {
   |                                                       ^^^^^^^^^^^^^^^^^^^ the `Err`-variant is at least 128 bytes
   |
   = help: try reducing the size of `hyper::Response<axum::body::Body>`, for example by boxing large elements or replacing it with `Box<hyper::Response<axum::body::Body>>`
   = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.92.0/index.html#result_large_err
View more details on GitHub Actions